feat(collectivex): chart KV-transfer scaling and lead kv-only runs with it / 为 KV 传输绘制扩展性图表并前置展示 - #689
Merged
Merged
Conversation
…th it The kv card rendered below the EP chart, so a kv-only run led with a legitimately empty chart and read as having no data. The kv section now renders above the EP explorer and grows a D3 chart: aggregate pull GB/s or burst latency against batch size (at the largest measured ISL, the concurrency-scaling story) or against ISL (at batch 1, the single-request handoff), with page-size and direction toggles, per-case series colored like the EP explorer, run-index dashes, and a toggleable legend. Paged rows only; the single-descriptor bulk ceiling stays a table column. 中文:此前 kv 卡片位于 EP 图表之下,仅含 kv 的运行首屏是一张必然为空的 图表,看似没有数据。现将 kv 区块移至 EP 浏览器之上,并新增 D3 图表: 聚合 pull 带宽(GB/s)或突发延迟对批大小(取最大实测 ISL,体现并发扩展) 或对 ISL(取批 1,体现单请求交接)作图,附页大小与方向切换、与 EP 一致 的按配置着色和按运行虚线、可切换图例。仅分页行入图;单描述符 bulk 上限 保留为表格列。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit abb357e. Configure here.
The bandwidth axis names the selected direction instead of always pull; legend selection is keyed to the current series set so newly checked runs start active instead of inheriting a stale toggle set; kv run dashes come from the explorer's shared selection-order index so a run keeps one dash pattern across both charts while loads settle. 中文:带宽轴标签跟随所选方向而非固定为 pull;图例选择与当前序列集合绑定, 新勾选的运行默认激活而不继承过期的切换状态;kv 虚线索引改用与 EP 浏览器 共享的选择顺序映射,加载过程中同一运行在两张图上保持一致的虚线样式。
A kv-only sweep was indistinguishable from an EP sweep in the run picker. Each row now carries EP and KV badges derived from the stored summary (kv_cases is absent on pre-kv summaries, which read as EP-only), with measured/requested counts in the badge tooltip. 中文:运行列表此前无法区分 kv-only 与 EP 运行。每行现按存储摘要显示 EP 与 KV 徽标(旧摘要无 kv_cases,视为仅 EP),悬浮提示含实测/请求 用例数。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #688, addressing two things from the first production look at kv runs:
What
Tests
中文说明
作为 #688 的后续,解决 kv 运行首次在生产环境展示时发现的两个问题:
测试:图表取点逻辑单测(批视图取最大 ISL、ISL 视图取批 1、方向与页过滤);本地 Chrome E2E 26/26 通过(图表渲染点数、三组切换、kv 区块位于 EP 图表之前、EP-only 不渲染卡片);lint、fmt、typecheck 通过(唯一失败的单测文件为与本改动无关、干净 master 上同样失败的时区敏感用例)。
Note
Low Risk
UI-only CollectiveX visualization and table changes; no API or auth changes. Regression risk is limited to chart data selection and layout ordering, covered by new unit and E2E tests.
Overview
KV-cache transfer is now a full section (
CollectiveXKvSection) with a log-log D3 chart (bandwidth vs latency, batch vs ISL, page size, pull/push), toggleable legend aligned with EP run dash patterns, and the existing data table underneath.CollectiveXKvTableis removed in favor of this section.Layout: The KV block renders above the EP explorer chart so kv-only runs show data before an empty EP chart.
Runs table: A Suites column shows EP and KV badges from
kv_casesvs total case counts (older summaries withoutkv_casesstay EP-only).Data layer:
collectiveXKvChartPointsand related helpers drive chart series (paged rows only; bulk stays in the table). Unit and Cypress tests cover chart toggles, DOM order, suite badges, and EP-only behavior.Reviewed by Cursor Bugbot for commit e0e07e6. Bugbot is set up for automated code reviews on this repo. Configure here.