Conversation
|
Please double check my work |
|
I've spot checked it, and I think it should be safe to merge |
|
Derekh HaShem vs. Derekh Hashem Small issue that is not a big deal, but I figured its worth mention since I saw it. |
Automated code reviewThis is an automated review (Claude), run by a Sefaria maintainer as part of a sweep through our long-open pull requests. A human is reading the results. @herzberg — thank you for this, and I want to acknowledge plainly that no maintainer ever replied to you. Every comment on this thread is your own, including "Please double check my work." That shouldn't have happened, and I'm sorry. The work itself was careful. You re-exported the corpus as of 2024-01-16, split it into reviewable per-category commits rather than one unreviewable blob, spot-checked the result, and flagged a genuine naming inconsistency ( Why it can no longer be merged. Two things happened while this was open:
The PR is also already in conflict with So this is genuinely obsolete — but through a change of architecture on our side, not through any fault in your work. We'd like to hear what you'd prefer rather than simply closing a PR that we left unanswered for two and a half years. Please join our developer Discord if you'd like to pick this up with us: 👉 https://sefaria.formstack.com/forms/sefaria_developer_discord_community Thanks for the effort, and again — sorry for the silence. |
Follow-up: this PR was closed automatically, not by a decisionShortly after the review above, we reset this repository's git history — moving ~14 GB of accumulated history into a read-only archive so a clone drops from ~14 GB to under 1 MB. That force-push auto-closed this PR. We did not expect it to: we believed GitHub only auto-closes a pull request when its base branch is deleted, and we rewrote I'm flagging it because the comment above said we wanted to hear from you "rather than close this on you after so long" — and then a migration closed it minutes later. That's a bad look and it wasn't the intent. We got the mechanics wrong; we didn't change our minds. Nothing of yours is lost. Your fork is untouched and your commits are intact, and the complete pre-reset history is preserved at Sefaria-Export-Archive. If you'd like this reopened to continue the conversation, say so and we'll reopen it — the diff view will be unusable (no common ancestor with the new root commit), but the thread still works. 👉 https://sefaria.formstack.com/forms/sefaria_developer_discord_community |
|
Hi — a note on where this stands. We had to make some changes to this repository (moving ~14 GB of git history into a read-only archive), and that's what closed your PR. Reopening isn't possible — GitHub blocks it because the merge base no longer exists. We're not asking you to re-submit this one, and that's not a judgement on the work: as noted in the review above, the issue you reported is already resolved in our current published data, so a new PR would have nothing left to fix. You were right; it just got fixed by another route while this sat unanswered. Please do join our developers Discord, though — we'd rather hear about the next thing you spot somewhere it will actually get seen: 👉 https://sefaria.formstack.com/forms/sefaria_developer_discord_community Thank you for the contribution, and sorry for how long it went without a reply. |
Note: This does not include any updates to
cltk-flatorcltk-full.In order to make the upload smoother, I created a short script to help commit/upload piece by piece.
Which provided these commands: