Add read-only support for Wyze Lock Bolt v2 (DX_LB2) - #242
Open
porkupine100 wants to merge 1 commit into
Open
porkupine100 wants to merge 1 commit into
porkupine100 wants to merge 1 commit into
Conversation
|
|
SecKatie
requested changes
Jul 8, 2026
SecKatie
left a comment
SecKatie
left a comment
Owner
There was a problem hiding this comment.
There are some unrelated changes to random comments, etc. in this PR can you remove those? I'd like to keep this focused on the feature that we're adding.
| try: | ||
| model_type = DeviceTypes(self.product_model) | ||
| return model_type | ||
| except ValueError: |
Owner
There was a problem hiding this comment.
Why swallow this error here? I don't like the change to this function actually. The purpose of it is a single responsibility of extracting a device type from a product type field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What device this adds: Wyze Lock Bolt v2 (DX_LB2)
What works: lock state (locked/unlocked), online status, battery level
What doesn't work yet: lock/unlock commands (API not yet identified)