fix: restore getCredentials import and remove demo-only changes#18
Merged
Merged
Conversation
nicomiguelino
force-pushed
the
fix/revert-get-credentials-changes
branch
from
91b4350 to
7ee3d09
Compare
- Re-import getCredentials from @screenly/edge-apps - Remove local getCredentials override added for demo - Remove debug console.log - Remove dashboard_id fallback, use content_id only
nicomiguelino
force-pushed
the
fix/revert-get-credentials-changes
branch
from
7ee3d09 to
f111601
Compare
There was a problem hiding this comment.
Pull request overview
Reverts demo-specific local changes in src/main.ts, restoring use of the library-provided getCredentials from @screenly/edge-apps and aligning the credential response shape ({ token, metadata: { instance_url } }). Also removes a stray debug log and a no-longer-supported dashboard_id setting fallback.
Changes:
- Re-import
getCredentialsfrom@screenly/edge-appsand remove the local override - Use
metadata.instance_urlfrom the new response shape (fixing the previously brokeninstanceUrlassignment) and drop theconsole.log('Renat!!!')debug statement - Drop the
dashboard_idsetting fallback, leavingcontent_idas the sole setting key
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicomiguelino
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCredentialsimport from@screenly/edge-apps, removing the local override added for the demoinstanceUrlassignment (was readinginstance_urlfrom wrong response shape)console.log('Renat!!!')dashboard_idfallback;content_idis the only setting key