Harden rendered API docs and JET defaults - #53
Merged
Conversation
Make autodocs coverage fail closed for filters and restrictive orders, and preserve target_modules when target_defined_modules is false. Add regression coverage for both behaviors. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
followup-conservative-qa
branch
from
August 15, 2026 10:06
88dd5e1 to
b86b5cf
Compare
ChrisRackauckas
marked this pull request as ready for review
August 15, 2026 10:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@autodocscoverage fail closed for dynamic or unknown scopes andFilter/Ordersettings.target_defined_modules=falsewithout dropping the defaulttarget_modules; preserve explicit target precedence.Scope
Only
src/SciMLTesting.jlandtest/runtests.jlare changed.Verification
julia +1.12 --startup-file=no --project=. -e 'using Pkg; Pkg.test()':SciMLTesting | 426 passed, 0 failed, 0 errored, 0 brokenjulia +1.12 --startup-file=no --project=@runic -m Runic --check src/SciMLTesting.jl test/runtests.jl: passedtypos src/SciMLTesting.jl test/runtests.jl: passedgit diff --check: passedThe installed JET version has removed the legacy
target_defined_moduleskeyword. FakeJET tests the legacy-key precedence, while the real-JET test validates the resultingtarget_modulespath. No tests are suppressed or weakened.Please ignore this draft until reviewed by @ChrisRackauckas.