fix: avoid CDP attachment when listing connected pages - #127
Open
mr-karan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium's remote debugging setting can allow page control while rejecting
Target.attachToTarget.browser.listPages()currently opens a page-level CDP session for every attached tab, so one rejected attachment makes the whole call fail.This change uses stable, daemon-local page IDs for connected browsers. IDs returned by
listPages()still work withgetPage(id), stay scoped to the browser that produced them, and are removed when the page closes. Browsers launched by dev-browser continue to return their native CDP target IDs.Tested with:
pnpm exec vitest run(155 tests)pnpm run buildpnpm run format:check