Skip to content

Lib: Fix v106 - #590

Merged
SamboyCoding merged 1 commit into
SamboyCoding:developmentfrom
Boxofbiscuits97:development
Jul 28, 2026
Merged

Lib: Fix v106#590
SamboyCoding merged 1 commit into
SamboyCoding:developmentfrom
Boxofbiscuits97:development

Conversation

@Boxofbiscuits97

Copy link
Copy Markdown
Contributor

Add fieldIndex check to include int.MaxValue as v106 sometimes includes it instead of a value of -1

A little bit of context on this is I was modding a game called Inside The Backrooms that was recently added to Thunderstore using MelonLoader and have run into this issue since the game was updated to use Unity 6.5 (6000.5.0f1). After running through hoops to get things working, I traced the issue back to Cpp2IL and it was caused by this. Hope this PR helps to make the tool better.

P.S. still actively getting my updated build to work correctly in MelonLoader natively, I'll put more updates in here as I go.

Add check to include int.MaxValue as v106 sometimes includes it instead of a value of -1
@SamboyCoding

Copy link
Copy Markdown
Owner

Ah, this tracks, it's actually the same value, it's just that dynamic-width indices read -1 as maxvalue, and 106 converted field index to be dynamic

@SamboyCoding
SamboyCoding merged commit b20ca0d into SamboyCoding:development Jul 28, 2026
8 checks passed
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30347751278

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.001%) to 36.303%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13467
Covered Lines: 5291
Line Coverage: 39.29%
Relevant Branches: 9071
Covered Branches: 2891
Branch Coverage: 31.87%
Branches in Coverage %: Yes
Coverage Strength: 164158.62 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants