Skip to content

Updating test structure to more effectively test async/sync tests and combine logic to reduce overall integration tests#1325

Open
BryanFauble wants to merge 2 commits intosynpy-1758-upgrade-dependenciesfrom
update-test-structure
Open

Updating test structure to more effectively test async/sync tests and combine logic to reduce overall integration tests#1325
BryanFauble wants to merge 2 commits intosynpy-1758-upgrade-dependenciesfrom
update-test-structure

Conversation

@BryanFauble
Copy link
Member

Problem:

  • The repo tests were very flakey and had issues with timeouts, duplicated logic, and causing a disproportionate amount of the Sage GH budget

Solution:

  • Remove the need to create a separate suite of async/sync tests and instead verify a few in the wrapper to verify logic.
  • Reuse some fixtures betweens tests like table logic so that fewer interactions with Synapse to set up the test cases is required
  • Creation of many unit tests to cover lines that were not previously tested, or to verify test cases that were integration tests but did not need to be

Testing:

  • Will review test runs, additionally I ran the tests on my local machine to review code coverage and found that they all passes with code coverage now around 80%

@BryanFauble BryanFauble requested a review from a team as a code owner February 18, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments