Remove redundant macOS bitcode generation job - #197
Merged
Merged
Conversation
Co-authored-by: yuleisui <7608399+yuleisui@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GitHub Actions workflow for LLVM bitcode generation
Remove redundant macOS bitcode generation job
Sep 29, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The skipped Windows test has no committed bitcode artifact, so it disappears from the generated test suite.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes redundant macOS bitcode generation while adapting Ubuntu generation to preserve Windows-specific bitcode.
Changes:
- Removes the
mac_buildworkflow job. - Preserves and skips regeneration of Windows-only bitcode.
- Reuses extracted filenames during compilation.
| File | Description |
|---|---|
generate_bc.sh |
Updates cleanup and Windows-specific artifact handling. |
.github/workflows/Test-Suite.yml |
Removes the redundant macOS job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+82
to
+84
| if [ "$td" = "mem_leak" ] && [ "$filename" = "leak_win_heap.c" ]; then | ||
| echo "$0: Skipping '$c_f' (preserving '$preserved_bc')" | ||
| continue |
Collaborator
|
@copilot the leak_win_heap.bc need to be committed into the repo under test_cases_bc/mem_leak folder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS job redundantly regenerated and pushed tracked bitcode, failing on platform-specific tests and a merge conflict. Ubuntu had already generated and uploaded the artifacts.
mac_build; retain Ubuntu as the sole bitcode generation and push job.