Repository navigation
Do not promote argmin VNNLIB properties to top-1 robustness; - #122
Merged
Merged
Conversation
…leNotFoundError for missing instance files
Rows with -1 on candidate class C ("C scores lowest") were promoted to
TOP1_ROBUST, which gave wrong FALSIFIED verdicts on ACAS Xu prop_5,
prop_9 and prop_10 (networks 1_1, 3_3 and 4_5); keep them UNSAFE_LINEAR.
CIFAR-100 keeps one top-1 query: both VNNLIB orientations canonicalise
to Y_true - Y_j <= 0. A missing file in an existing category raises
FileNotFoundError naming the path instead of downloading.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 95 95
Lines 23009 23007 -2
=======================================
- Hits 17860 17859 -1
+ Misses 5149 5148 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows with -1 on candidate class C ("C scores lowest") were promoted to TOP1_ROBUST, which gave wrong FALSIFIED verdicts on ACAS Xu prop_5, prop_9 and prop_10 (networks 1_1, 3_3 and 4_5);
keep them UNSAFE_LINEAR. CIFAR-100 keeps one top-1 query: both VNNLIB orientations canonicalise to Y_true - Y_j <= 0.
Fix with A missing file in an existing category raises FileNotFoundError naming the path instead of downloading.