New proposal for Engine::Displayable#802
Open
nmellado wants to merge 145 commits into
Open
Conversation
nmellado
added
enhancement
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-candidate #802 +/- ##
=====================================================
- Coverage 44.49% 44.31% -0.19%
=====================================================
Files 372 371 -1
Lines 28136 28422 +286
=====================================================
+ Hits 12519 12594 +75
- Misses 15617 15828 +211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nmellado
force-pushed
the
clean_displayable
branch
2 times, most recently
from
5a16cbe to
fa260e4
Compare
nmellado
force-pushed
the
clean_displayable
branch
from
3aa14e1 to
629f408
Compare
dlyr
force-pushed
the
clean_displayable
branch
2 times, most recently
from
757a5e9 to
1e88873
Compare
dlyr
force-pushed
the
clean_displayable
branch
2 times, most recently
from
d2bf2c5 to
2d148ca
Compare
dlyr
added
Core
dlyr
force-pushed
the
clean_displayable
branch
from
12af541 to
2fff241
Compare
nmellado
force-pushed
the
clean_displayable
branch
from
435c672 to
60b8cdf
Compare
Contributor
|
note for futur skinning https://cims.nyu.edu/gcl/papers/EG2014-Lighting.pdf |
dlyr
force-pushed
the
clean_displayable
branch
from
8947bd5 to
8f5a25f
Compare
dlyr
force-pushed
the
clean_displayable
branch
3 times, most recently
from
f5df674 to
e9f3e16
Compare
[core] Expose LayerKeyHash struct Allow to reuse layers hash function outside of MultiIndexedGeometry
[engine] Remove unused class IndexedAttribArrayDisplayable [engine] Prepare classes attributes (do not compile) Code does not compile as only the attributes have been defined, but the methods have not been updated. [core] Mark GeometryIndexLayerBase::size() as const [engine] define all virtual function for GeometryDisplayable (will be deleted). When transition will be complete, these accessor might not be necessary. [engine] GeometryDisplayable updateGL (not tested). [engine] GeometryDisplayable works, for HelloRadium. triangulate
Since not used and error prone, if needed add back as explicit. Also remove redundent typename keyword.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Simplify API for
Engine::Displayableand inheriting classes by usingCore::MultiIndexGeometry.What is the current behavior? (You can also link to an open issue here)
Mesh types are statically typed on Core Mesh types.
What is the new behavior (if this is a feature change)?
Take benefit of
MultiIndexGeometryto allow dynamic typing of the rendered objects:Engine::GeometryDisplayablewill store a collection of geometry layers.Expected API (right):
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Will impact client code explicitly working with
Engine::Displayableand inhering classes.Other information: