refactor test framework#333
refactor test framework#333benjaminxscott wants to merge 4 commits intoSTIXProject:masterfrom benjaminxscott:test-refactor
Conversation
|
Which files did you trim? Was it any of the individual regression tests? IMO all of the regression tests should probably stay (along w/ our samples and whatnot) but I'm totally fine trimming back testing against all those VERIS files. Agree w/ squashing schemas and schemas-tests Undecided on negative tests, I can see why they might be necessary to ensure that fields were actually removed but in general are very confusing. Agree w/ glob. If we get further consensus I'd be OK merging. |
|
all regression tests are kept, under veris files were trimmed |
|
perfect. @bworrell thoughts? |
|
@johnwunder, @bschmoker I think this is probably fine. I'm curious to know which VERIS files were removed and why (though I can guess there was just a lot of redundancy between them all). |
|
@bworrell - all of them besides a few - lmk if it's cool to |
📝 totally optional merge - meant as a PoC for how I would do tests from scratch
This branch:
@johnwunder cc:@gtback