fix(deps): selenium 4.45.0 + seleniumlibrary 6.9.0 + urllib3 2.7.0 security stopgap - #4006
Draft
jstvz wants to merge 11 commits into
Draft
fix(deps): selenium 4.45.0 + seleniumlibrary 6.9.0 + urllib3 2.7.0 security stopgap#4006jstvz wants to merge 11 commits into
jstvz wants to merge 11 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…rms.robot Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…rllib3 2.x Co-authored-by: Cursor <cursoragent@cursor.com>
…y mock Co-authored-by: Cursor <cursoragent@cursor.com>
Two complementary fixes let the proven bulk-API cassettes replay under urllib3 2.x without re-recording, fixing test_upsert_external_id_field and test_upsert_complex_fields__bulk: 1. _body_to_bytes / sf_before_record_request: urllib3 2.x presents the bulk-upload body as a bytes iterator that vcr.Request stores as a list of int byte-values and re-wraps as a fresh iterator on every .body access. The old per-chunk bytes(int) coercion produced zero-filled garbage, and the request filter mutated .body without clearing _was_iter, so each match pass re-corrupted the body. Coerce int chunks correctly and materialize the body once via _normalize_request_body (clears _was_iter/_was_file) so repeated filter passes are idempotent. 2. salesforce_matcher: de-frame chunked-transfer bodies on both sides via a vendored vcr.matchers._dechunk. urllib3 1.x baked chunk framing into the recorded bodies; urllib3 2.x sends them unframed. Canonicalizing live and taped bodies lets the existing cassettes match (both fixes are required: disabling de-chunk alone reproduces CannotOverwriteExistingCassetteException). Adds 5 unit tests (bytes-iterator coercion + filter idempotency). Full suite: 1 failed / 3248 passed / 37 skipped; the single failure (test_check_components::test_collect_components_from_paths) is pre-existing on dev base 2df450c and out of scope. Pre-commit: ruff + ruff-format + prettier pass. pyright skipped via SKIP=pyright (pre-existing whole-repo failure in cumulusci/tasks/github/util.py under Python 3.14, reproduced on clean dev base; this is a per-hook skip, not --no-verify). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades selenium 3.141.0 -> 4.x, robotframework-seleniumlibrary 5.x -> 6.x, and unblocks urllib3 -> 2.x. Clears 5 urllib3-1.26.20 advisories and selenium CVE-2023-5590. Supersedes Dependabot #3977.
Does not touch the separate Playwright migration (ADR 0004).
Changes
find_element_by_*call sites tofind_element(By.X, value).selenium<4->selenium>=4,<5androbotframework-seleniumlibrary<6->>=6,<7.Test plan
test_check_components) that reproduces on a cleandevcheckout.Commandenum presence,WebDriver.executesignature,ProtocolErrorunder urllib3 2.x,Byattribute presence, deprecated call-site inventory, SeleniumLibrary 5->6 keyword delta (none affecting CCI).Opened as draft pending final review before merge.