fix: 운동 안 함 선택 시 루틴 질문 없이 바로 회원가입 완료 - #205
Merged
Merged
Conversation
운동 선택 화면에서 "운동 안 함"을 고르면 exercise-detail(루틴 질문) 페이지로 넘어가지 않고 온보딩을 즉시 제출하도록 변경. 두 화면에서 중복되던 제출/409 처리/이동 로직은 useCompleteOnboarding 훅으로 추출.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JioCoder
self-requested a review
September 1, 2026 02:09
Contributor
|
확인했습니당 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCompleteOnboarding훅으로 추출해 재사용Changes
features/onboarding/hooks/use-complete-onboarding.ts(신규): 온보딩 제출 + 이미 등록된 사용자(409) 처리 +/(tabs)이동 공통 로직features/onboarding/components/onboarding-exercise-screen.tsx: "운동 안 함" 선택 시exercise-detail로 push하지 않고 바로complete()호출, 버튼 로딩 상태 표시features/onboarding/components/onboarding-exercise-detail-screen.tsx: 중복 로직을 공통 훅으로 교체 (동작 변화 없음)exerciseDuration/exerciseFrequency는 API 타입상 optional이라 "운동 안 함" 케이스에서 값 없이 제출해도 문제없음을 확인했습니다.Test plan
(tabs)화면으로 이동하는지 확인🤖 Generated with Claude Code