Fix #2530 - Intermittent arm64 segfault caused by data races in parallel optimizer#2531
Closed
akenmorris wants to merge 1 commit intomasterfrom
Closed
Fix #2530 - Intermittent arm64 segfault caused by data races in parallel optimizer#2531akenmorris wants to merge 1 commit intomasterfrom
akenmorris wants to merge 1 commit intomasterfrom
Conversation
…lel optimizer Suppress ParticleSystem observer events during the TBB parallel section in GradientDescentOptimizer and batch-update via SynchronizePositions() afterward. Replace unsynchronized max_change with atomic reduction. Add lldb stack trace capture to arm64 CI for future crash diagnosis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress ParticleSystem observer events during the TBB parallel section in GradientDescentOptimizer and batch-update via SynchronizePositions() afterward. Replace unsynchronized max_change with atomic reduction. Add lldb stack trace capture to arm64 CI for future crash diagnosis.