Conversation
Contributor
SummaryThe following content is AI-generated and provides a summary of the pull request: Title: Fix prompt/message merging validation in orchestration config ContextNo related issue provided. What this PR does and why it is neededCategory: Bug Fix / Refactor This PR extracts prompt/message merging from The change fixes a validation gap where missing prompt templates and missing request messages were not detected when no prompt was configured. The new helper initializes an empty template for validation purposes, merges request messages without mutating the input configuration, and preserves template references unchanged. Changes
PR Bot InformationVersion:
|
resolvePromptTemplate was returning a plain `{ template: [...] }` object,
discarding other properties like `tools` and `response_format` that
mergeOrchestrationConfig had already set on the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildCompletionModulesConfiginto a dedicatedmergePromptWithMessagesfunction