mcf: expand Error into a proper enum
#2119
Merged
+67
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old error type was a simple unit struct that couldn't express anything. This replaces it with an enum that can express various error conditions, including Base64 encoding errors, which might be helpful when trying to support a myriad of different Base64 encodings.
tarcieri
force-pushed
the
mcf/error-enum
branch
from
5bcbe07 to
3498274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old error type was a simple unit struct that couldn't express anything.
This replaces it with an enum that can express various error conditions, including Base64 encoding errors, which might be helpful when trying to support a myriad of different Base64 encodings.