util/attributes: Check that #[target_feature] is only used on unsafe … #4356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
fix/target-feature-unsafe-4234
branch
3 times, most recently
from
6e8d514 to
3285e5d
Compare
Member
|
Thanks for your contribution! A bit similar as my other comment in your other PR, can you be more precise in the changelog and clearly identify which member you have modifying? ? |
Contributor
Author
|
thanks for the review . will change all the commit messages to be more precise in the changelog. |
…functions The #[target_feature] attribute allows code generation that may not be supported by the runtime hardware, making it inherently unsafe. This patch adds a check to ensure it is only applied to functions declared as 'unsafe', matching rustc behavior (E0658). Fixes Rust-GCC#4234 gcc/rust/ChangeLog: * util/rust-attributes.cc: (AttributeChecker::visit): Error if target_feature is on safe function. gcc/testsuite/ChangeLog: * rust/compile/target_feature-unsafe.rs: New test. * rust/compile/unsafe11.rs: Mark function as unsafe to satisfy new check. Signed-off-by: Jayant Chauhan <[email protected]>
Pasta-coder
force-pushed
the
fix/target-feature-unsafe-4234
branch
from
3285e5d to
212d55f
Compare
Contributor
Author
|
drafted to resolve merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #[target_feature] attribute allows code generation that may not be supported by the runtime hardware, making it inherently unsafe. This patch adds a check to ensure it is only applied to functions declared as 'unsafe', matching rustc behavior (E0658).
Fixes #4234
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: