util/attributes: Fix/target feature malformed 4233 #4349
Merged
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
fix/target-feature-malformed-4233-clean
branch
12 times, most recently
from
679e3ef to
1689757
Compare
Pasta-coder
changed the title
Pasta-coder
force-pushed
the
fix/target-feature-malformed-4233-clean
branch
from
6b3d4a1 to
0ca7bc0
Compare
Emit a diagnostic when #[target_feature] is used without arguments, matching rustc behavior. This prevents silent acceptance of empty attributes and provides a helpful diagnostic that shows the expected form. Fixes Rust-GCC#4233 gcc/rust/ChangeLog: * util/rust-attributes.cc (AttributeChecker::visit): Emit diagnostic. gcc/testsuite/ChangeLog: * rust/compile/target_feature-malformed-4233.rs: New test. Signed-off-by: Jayant Chauhan <[email protected]>
Pasta-coder
force-pushed
the
fix/target-feature-malformed-4233-clean
branch
from
0ca7bc0 to
a6e7b02
Compare
Contributor
Author
|
@P-E-P please review thankyou . |
P-E-P
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4233
Emit a diagnostic when
#[target_feature]is used without arguments,matching rustc behavior.