417 convert classifiers to numpower - #418
Open
apphp wants to merge 11 commits into
Open
Conversation
andrewdalpino
left a comment
andrewdalpino
left a comment
Member
There was a problem hiding this comment.
Looks good @samuel-akopyan nice work as usual. I a have a couple questions and things that stood out to me.
| } | ||
|
|
||
| return NumPower::array($result); | ||
| $max = NumPower::reshape(NumPower::array($maxima), [1, $columns]); |
Member
There was a problem hiding this comment.
Did we forget to implement this during the Activation Functions sprint? Was it intentional to leave out due to the NumPower max() API limitation?
| $expected = []; | ||
|
|
||
| foreach ($labels as $label) { | ||
| $dist = []; |
Member
There was a problem hiding this comment.
What was the purpose of this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.