feat: standardize model selectors across all providers #10294
+550
−266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
Contributor
Re-review complete. No outstanding issues.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
Collaborator
|
LGTM |
mrubens
reviewed
Jan 7, 2026
mrubens
reviewed
Jan 7, 2026
Comment on lines
+771
to
+762
| // Clear custom ARN if not using custom ARN option (Bedrock) | ||
| if (modelId !== "custom-arn" && selectedProvider === "bedrock") { | ||
| setApiConfigurationField("awsCustomArn", "") | ||
| } |
Collaborator
There was a problem hiding this comment.
Same comment here (I know this was there before) - smells like a more general problem where we're not clearing out data correctly on model changes.
Contributor
There was a problem hiding this comment.
Fixaroo
See task on Roo Cloud
Fixed the reported issue. All local checks passed.
Collaborator
Author
Contributor
Verified the Z.ai default model fix is already properly implemented:
No additional changes required - the review issue is already resolved. |
Replace various model selection UI patterns with consistent ModelPicker component: - Replace Select dropdowns for static providers (Anthropic, Bedrock, etc.) - Replace text input + radio buttons for Ollama and LM Studio - Replace Select for VSCodeLM with transform functions for vendor/family object - Add providerModelConfig.ts with service configuration helpers - Add unit tests for new utility functions
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
…delConfig Move provider-specific Z.ai default model ID logic from ApiOptions.tsx template into getDefaultModelIdForProvider() utility function. This keeps the ApiOptions component provider-agnostic and centralizes the logic for handling China vs International entrypoints.
hannesrudolph
force-pushed
the
feat/standardize-model-selectors
branch
from
967fa3f to
e0a24c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces various model selection UI patterns with a consistent search-style ModelPicker component across all providers, giving users a unified experience as outlined in
plans/standardize-model-selector.md.Changes
New Files
webview-ui/src/components/settings/utils/providerModelConfig.ts- Helper utilities including:PROVIDER_SERVICE_CONFIG- Maps providers to service names/URLsgetDefaultModelIdForProvider(),getStaticModelsForProvider()shouldUseGenericModelPicker()- Determines which providers use generic ModelPickerwebview-ui/src/components/settings/utils/__tests__/providerModelConfig.spec.ts- 20 unit testsModified Files
ModelPicker.tsx- Added new props:label,valueTransform,displayTransform,onModelChange; added new ModelIdKey types for Ollama, LMStudio, VSCodeLMApiOptions.tsx- Replaced Select-based generic picker with ModelPicker usingshouldUseGenericModelPicker()Ollama.tsx- Replaced VSCodeTextField + VSCodeRadioGroup with ModelPickerLMStudio.tsx- Replaced text + radio with ModelPicker; added second ModelPicker for draft modelVSCodeLM.tsx- Replaced Select with ModelPicker using transform functions for vendor/family objectApiOptions.provider-filtering.spec.tsx- Added Popover/Command component mocksImplementation Details
ModelPickerviashouldUseGenericModelPicker()valueTransform/displayTransformto handle{ vendor, family }object formatgetStaticModelsForProvider()errorMessagepropTest Results
All tests pass (356 test files, 4957 tests passed, 48 skipped).
Important
Standardizes model selection UI with a
ModelPickercomponent across providers, enhancing consistency and user experience.ModelPickercomponent across all providers.shouldUseGenericModelPicker()to determine providers using the generic picker.ApiOptions.tsx.ModelPickerwith new props:label,valueTransform,displayTransform,onModelChange.ApiOptions.tsx,Ollama.tsx,LMStudio.tsx,VSCodeLM.tsxto useModelPicker.providerModelConfig.tsfor provider configurations and utility functions.providerModelConfig.spec.tsto verify configurations and picker logic.This description was created by
for e0a24c8. You can customize this summary. It will automatically update as commits are pushed.