fix(fuselage): improve a11y for MultiSelect components#1940
Draft
juliajforesti wants to merge 5 commits intomainfrom
Draft
fix(fuselage): improve a11y for MultiSelect components#1940juliajforesti wants to merge 5 commits intomainfrom
MultiSelect components#1940juliajforesti wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 618482b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
juliajforesti
force-pushed
the
fix/multiselect-a11y
branch
from
3af5a82 to
618482b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
MultiSelectaria attributes were being spread into the div wrapping the input. Now it's correctly going to the inputIssue(s)
Further comments