Skip to content

refactor(telemetry): remove duplicated TelemetryMap and TelemetryEvents types #39996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akashogz wants to merge 2 commits into
base: develop
Choose a base branch
from
+6 −9
Open

refactor(telemetry): remove duplicated TelemetryMap and TelemetryEvents types #39996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7bd5b2
fix(message-parser): remove TODO and apply color token in attachment …
akashogz Mar 30, 2026
6010f1b
refactor(telemetry): remove duplicated TelemetryMap and TelemetryEven…
akashogz Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/meteor/client/components/message/content/attachments/default/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ type FieldProps = {
value: ReactNode;
} & Omit<ComponentProps<typeof Box>, 'title' | 'value'>;

// TODO: description missing color token
const Field = ({ title, value, ...props }: FieldProps) => (
<Box mb={4} pi={4} width='full' flexBasis={100} flexShrink={0} color='default' {...props}>
<Box fontScale='p2m'>{title}</Box>
{value}
<Box fontScale='p2m' color='hint'>{title}</Box>
<Box fontScale='p1m' color='default'>
{value}
</Box>
</Box>
);

Expand Down
7 changes: 1 addition & 6 deletions packages/core-services/src/types/ITelemetryEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
type updateCounterDataType = { settingsId: string };
type slashCommandsDataType = { command: string };

// TODO this is duplicated from /packages/rest-typings/src/v1/statistics.ts
export type TelemetryMap = { slashCommandsStats: slashCommandsDataType; updateCounter: updateCounterDataType };
export type TelemetryEvents = keyof TelemetryMap;
import type { TelemetryMap, TelemetryEvents } from '@rocket.chat/rest-typings';

export interface ITelemetryEvent {
register: (name: TelemetryEvents, fn: () => Promise<any> | void) => void;
Expand Down
1 change: 1 addition & 0 deletions packages/rest-typings/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ export * from './v1/auth';
export * from './v1/cloud';
export * from './v1/banners';
export * from './default';
export * from './v1/statistics';

// Export the ajv instance for use in other packages
export * from './v1/Ajv';