chore: deprecate insertOrUpdateSound and uploadCustomSound meteor methods#39725
chore: deprecate insertOrUpdateSound and uploadCustomSound meteor methods#39725nazabucciarelli wants to merge 3 commits intodevelopfrom
Conversation
…DeprecationLogger
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 0c3e0fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39725 +/- ##
===========================================
- Coverage 70.94% 70.54% -0.40%
===========================================
Files 3207 3256 +49
Lines 113958 116542 +2584
Branches 20694 21053 +359
===========================================
+ Hits 80842 82220 +1378
- Misses 31059 32267 +1208
+ Partials 2057 2055 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
CORE-1898 Create Custom Sounds API endpoints (update/create) to use them instead of Meteor methods and add file validations
Steps to test or reproduce
Further comments