Skip to content

refactor: remove obsolete RoomView state type - #7672

Merged
diegolmello merged 2 commits into
native-34-roomview-hooksfrom
diegolmello/simpler-finding-07
Sep 11, 2026
Merged

refactor: remove obsolete RoomView state type#7672
diegolmello merged 2 commits into
native-34-roomview-hooksfrom
diegolmello/simpler-finding-07

Conversation

@diegolmello

@diegolmello diegolmello commented Sep 11, 2026

Copy link
Copy Markdown
Member

Proposed changes

Remove the obsolete IRoomViewState aggregate left over from the RoomView class component. The six Last Seen annotations now use Date | null directly, and member helpers reference the live RoomState owner while preserving member: any.

This is a three-file type/import cleanup with no runtime changes.

Issue(s)

Follow-up to #7482; targets its native-34-roomview-hooks branch.

How to test or reproduce

  • pnpm format-lint passed, including TypeScript compilation.
  • Existing RoomStore and useRoomInit suites passed.
  • TZ=UTC pnpm test --runInBand --watchman=false passed: 315 suites, 2,896 tests, 426 snapshots.
  • No remaining tracked-file references to IRoomViewState.

Screenshots

Not applicable; no visual changes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Existing tests are unchanged. Astra standards and specification reviews reported no findings.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…iegolmello/simpler-finding-07

# Conflicts:
#	app/views/RoomView/components/MessageRow.tsx
@diegolmello
diegolmello marked this pull request as ready for review September 11, 2026 16:45
@diegolmello
diegolmello merged commit 9d2982a into native-34-roomview-hooks Sep 11, 2026
7 of 10 checks passed
@diegolmello
diegolmello deleted the diegolmello/simpler-finding-07 branch September 11, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant