regression: custom emoji rendering as raw shortname in reaction bar and emoji picker - #7671
regression: custom emoji rendering as raw shortname in reaction bar and emoji picker#7671OtavioStasiak wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used📓 Path-based instructions (3)Format JavaScript and TypeScript code with Oxfmt using the repository configuration: tabs, single quotes, 130-character width, no trailing commas, omitted arrow-function parentheses where possible, and same-line brackets.📄 CodeRabbit inference engine (CLAUDE.md) Files:
Use descriptive names for functions, variables, and classes that clearly convey their purpose Write comments that explain the 'why' behind code decisions, not the 'what' Keep functions small and focused on a single responsibility Use const...📄 CodeRabbit inference engine (AGENTS.md) Files:
Use TypeScript for type safety; add explicit type annotations to function parameters and return types Prefer interfaces over type aliases for defining object shapes in TypeScript Use enums for sets of related constants rather than magic str...📄 CodeRabbit inference engine (AGENTS.md) Files:
🧠 Learnings (1)📚 Learning: 2026-06-25T18:37:25.526ZApplied to files:
🔇 Additional comments (3)
WalkthroughThe change resolves string emoji names through custom emoji lookup in the emoji picker and message action headers. Unicode rendering remains the fallback when no custom emoji matches. Tests cover both custom and Unicode rendering. ChangesEmoji rendering
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to Custom emoji names now render correctly while unmatched names retain Unicode fallback behavior. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
Long-pressing a message showed the raw shortname (:clap:) in the reactions top bar when a custom emoji had the same name as a built-in one. The same issue happened in the emoji picker's Frequently Used tab.
This regression was introduced by #7462, where useShortnameToUnicode started returning the shortname when a custom emoji owns that name. These components were still deciding custom vs. built-in based only on the item's type.
This PR resolves string shortnames against the custom emoji map and renders CustomEmoji when needed. It also fixes the Header testID/accessibilityLabel for custom emojis and adds unit tests.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1542
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
New Features
Tests