Skip to content

Add app name validation #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aditya-vegi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add app name validation #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3248154
Add app type selection prompt to create command
Aditya-vegi Mar 25, 2026
a92c1ee
Add app name validation to create command
Aditya-vegi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/commands/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ export default class Create extends Command {
this.log('We need some information first:');
this.log('');

const appType = await cli.prompt(
chalk.bold(' App Type (chatbot/integration)'),
{ default: 'chatbot' }
);

this.log(`Selected App Type: ${chalk.green(appType)}`);
this.log('');

const { flags } = this.parse(Create);
info.name = flags.name ? flags.name : await cli.prompt(chalk.bold(' App Name'));
info.nameSlug = VariousUtils.slugify(info.name);
Expand All @@ -53,6 +61,12 @@ export default class Create extends Command {
info.author.homepage = flags.homepage ? flags.homepage : await cli.prompt(chalk.bold(' Author\'s Home Page'));
info.author.support = flags.support ? flags.support : await cli.prompt(chalk.bold(' Author\'s Support Page'));


if (!/^[a-z0-9-]+$/i.test(info.name)) {
this.error('App name must contain only letters, numbers, and hyphens (no spaces or special characters)');
return;
}

const folder = path.join(process.cwd(), info.nameSlug);

cli.action.start(`Creating a Rocket.Chat App in ${ chalk.green(folder) }`);
Expand Down