Skip to content

Apply ruff/pygrep-hooks rule PGH003 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DimitriPapadopoulos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply ruff/pygrep-hooks rule PGH003 #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/create_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import argparse
from pathlib import Path

import yaml # type: ignore
import yaml
from jinja2 import Environment, FileSystemLoader, select_autoescape

apt_based = [
Expand Down
8 changes: 2 additions & 6 deletions neurodocker/reproenv/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,8 +660,7 @@ def copy(

@_log_instruction
def env(self, **kwds: str) -> SingularityRenderer:
# TODO: why does this raise a type error?
self._environment.extend(kwds.items()) # type: ignore
self._environment.extend(kwds.items())
return self

@_log_instruction
Expand Down Expand Up @@ -695,10 +694,7 @@ def install(self, pkgs: list[str], opts=None) -> SingularityRenderer:

@_log_instruction
def label(self, **kwds: str) -> SingularityRenderer:
# TODO: why are we getting this error?
# Argument 1 to "update" of "dict" has incompatible type
# "Dict[str, Mapping[str, str]]"; expected "Mapping[str, str]"
self._labels.update(kwds) # type: ignore
self._labels.update(kwds)
return self

@_log_instruction
Expand Down
2 changes: 1 addition & 1 deletion neurodocker/reproenv/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
try:
from yaml import CSafeLoader as SafeLoader
except ImportError: # pragma: no cover
from yaml import SafeLoader # type: ignore # pragma: no cover
from yaml import SafeLoader # type: ignore[assignment] # pragma: no cover

from neurodocker.reproenv.exceptions import (
RendererError,
Expand Down
2 changes: 1 addition & 1 deletion neurodocker/reproenv/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def versions(self) -> set[str]:
def dependencies(self, pkg_manager: str) -> list[str]:
deps_dict = self._template.get("dependencies", {})
# TODO: not sure why the following line raises a type error in mypy.
return deps_dict.get(pkg_manager, []) # type: ignore
return deps_dict.get(pkg_manager, []) # type: ignore[return-value]

def install(self, pkgs: list[str], opts: str = None) -> str:
raise NotImplementedError(
Expand Down