Skip to content

PEP 735 compliance#705

Open
DimitriPapadopoulos wants to merge 1 commit intoReproNim:masterfrom
DimitriPapadopoulos:PEP735
Open

PEP 735 compliance#705
DimitriPapadopoulos wants to merge 1 commit intoReproNim:masterfrom
DimitriPapadopoulos:PEP735

Conversation

@DimitriPapadopoulos
Copy link

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's dependency management by adopting the specifications outlined in PEP 735. This change primarily involves restructuring how optional dependency groups are defined in pyproject.toml and updating the corresponding installation instructions, ensuring better adherence to Python packaging standards and improving clarity for developers.

Highlights

  • PEP 735 Compliance: The project's dependency management has been updated to align with PEP 735, standardizing how optional dependencies are declared and installed.
  • pyproject.toml Update: The pyproject.toml file now uses the [dependency-groups] table instead of [project.optional-dependencies] for defining optional dependency sets.
  • Installation Instructions: The README.md has been updated to reflect the new pip install --group syntax for installing optional dependency groups, replacing the older .[all] syntax.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • README.md
    • Updated the pip install command for installing all optional dependencies to use the --group all syntax.
  • pyproject.toml
    • Replaced the [project.optional-dependencies] table with [dependency-groups] to define optional dependency sets.
    • Modified the 'all' dependency group definition to use include-group for 'dev', 'doc', and 'minify'.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/docker_build.jinja
    • .github/workflows/docs.yml
    • .github/workflows/pull-request.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims for PEP 735 compliance by migrating from [project.optional-dependencies] to [dependency-groups]. While this is a forward-looking change, it introduces a couple of issues. First, the developer installation command in README.md uses a --group flag that is not yet supported by pip, making the instructions non-functional. Second, the dev dependency group in pyproject.toml incorrectly references the minify group as an extra, which will cause dependency resolution to fail. My review includes suggestions to address these issues.

Note: Security Review has been skipped due to the limited scope of the PR.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft March 3, 2026 20:28
@DimitriPapadopoulos
Copy link
Author

Pushed a new commit to fix an issue.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 4, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant