Skip to content

refactor: separate analysis#446

Open
tristan-f-r wants to merge 16 commits intoReed-CompBio:mainfrom
tristan-f-r:ml-separate
Open

refactor: separate analysis#446
tristan-f-r wants to merge 16 commits intoReed-CompBio:mainfrom
tristan-f-r:ml-separate

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Nov 26, 2025

Splits analysis into a more detailed configuration, allowing parts of the Snakemake workflow to depend only on parts of the config. This has the con of making it more annoying to blanket-enable all analysis. Closes #331.

@read-the-docs-community
Copy link

read-the-docs-community bot commented Nov 26, 2025

Documentation build overview

📚 spras | 🛠️ Build #31218769 | 📁 Comparing fb4c0fe against latest (18f2cf8)


🔍 Preview build

Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
fordevs/spras.config.html 📝 modified
fordevs/spras.html 📝 modified
tutorial/advanced.html 📝 modified
tutorial/beginner.html 📝 modified
tutorial/intermediate.html 📝 modified

@tristan-f-r tristan-f-r added analysis Analysis of PRA outputs refactor Changes that don't actually improve anything except for code quality. labels Nov 26, 2025
@tristan-f-r tristan-f-r marked this pull request as ready for review November 26, 2025 00:54
@tristan-f-r tristan-f-r requested a review from ntalluri November 26, 2025 23:42
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Jan 9, 2026
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Jan 10, 2026
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Jan 31, 2026
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Jan 31, 2026
ensemble:
include: true
aggregate_per_algorithm: true
evaluation:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the ML code and evaluation to be separate analysis options in the config even though they are internally coupled.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, it should be analysis.evaluation and not analysis.ensemble.evaluation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(analysis.ensemble.evaluation -> analysis.evaluation?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at comments for config/config.yaml about how to separate evaluation and ML.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at comments for config/config.yaml about how to separate evaluation and ML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analysis Analysis of PRA outputs refactor Changes that don't actually improve anything except for code quality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate evaluation and machine learning steps into individual functions

2 participants