Draft
Conversation
tristan-f-r
commented
Jul 29, 2025
.github/workflows/test-spras.yml
Outdated
| - name: Run tests | ||
| shell: bash --login {0} | ||
| # Verbose output and disable stdout and stderr capturing | ||
| run: pytest -vs --ignore=test/AllPairs --ignore=test/BowTieBuilder --ignore=test/DOMINO --ignore=test/MEO --ignore=test/MinCostFlow --ignore=test/OmicsIntegrator1 --ignore=--ignore=test/OmicsIntegrator2 --ignore=test/PathLinker --ignore=test/ResponseNet --ignore=test/RWR --ignore=test/ST_RWR |
Collaborator
Author
There was a problem hiding this comment.
This could be a good time to begin moving algorithms to their own folder.
Collaborator
There was a problem hiding this comment.
Why do we have to ignore so many tests?
Collaborator
Author
There was a problem hiding this comment.
Docker doesn't work on windows in GitHub CI. It would be good to at least test anything in Windows that doesn't rely on docker. [Earlier, I believe you had issues running SPRAS tests on Windows because of path issues with the analysis tests]
Collaborator
There was a problem hiding this comment.
The windows-2025 runner lists these tools
- Docker 27.5.1
- Docker Compose v2 2.32.2
- Docker-wincred 0.9.3
Did Docker not work?
tristan-f-r
added
the
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can have Windows CI if we ignore all of the important (docker) tests! I'm testing this through CI, so it will be a bit. I'm specifically doing this to tackle #98, and make it testable at CI-time. I have a suspicion as to what the problem is.