Fix block warning messages not translating on dedicated servers#147
Closed
Eldrinn-Elantey wants to merge 43 commits into
Closed
Fix block warning messages not translating on dedicated servers#147Eldrinn-Elantey wants to merge 43 commits into
Eldrinn-Elantey wants to merge 43 commits into
Conversation
Co-authored-by: Connor Colenso <colen@CONNORSPC>
Co-authored-by: Martin Robertz <dream-master@gmx.net>
Co-authored-by: Martin Robertz <dream-master@gmx.net>
Co-authored-by: Martin Robertz <dream-master@gmx.net>
…ne Break, etc. (#30)
Co-authored-by: Martin Robertz <dream-master@gmx.net>
Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
Co-authored-by: WhyDoLogic <84210614+WhyDoLogic@users.noreply.github.com> Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
…bs and wireless connectors correctly (#37) Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
…t without server restart (#36)
…es (#39) Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
#43) Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
Co-authored-by: RecursivePineapple <recursive_pineapple@proton.me>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Martin Robertz <dream-master@gmx.net> Co-authored-by: UltraProdigy <187078471+UltraProdigy@users.noreply.github.com>
Co-authored-by: LazyFleshWasTaken <40587985+LazyFleshWasTaken@users.noreply.github.com>
These warnings were translated with StatCollector on the server, whose locale is always en_US, and the resulting English string was then passed back in as a translation key. Clients never saw a real key, so the text stayed English regardless of their language. Send the key and args instead so the client translates it. Tested in-game with ru_RU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block placement and move warnings were translated with StatCollector on the server, whose locale is always en_US, and the English result was then passed back in as a translation key. Clients never got a real key, so these messages stayed English regardless of language. Now the key and args are sent so the client translates it. Tested in-game with the pack's ru_RU.