-
Notifications
You must be signed in to change notification settings - Fork 1k
add requires_utf8 argument to tests #7388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7388 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 87 87
Lines 16737 16741 +4
=======================================
+ Hits 16563 16567 +4
Misses 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 8d85972 Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
Sorry if I'm late to note this, but wouldn't a more reliable test for this be the same thing as we currently use for ñ in test 2266? A test may require some symbols (ñ, ü, ん) to be representable in the native encoding. The symbols may be represented using Unicode escapes ( |
Good point. I have integrated this for the utf8_check. |
…' into tests_requires_utf8

Closes #7336
Closes #1343
Closes #7333