Skip to content

Conversation

@ldmpub
Copy link
Contributor

@ldmpub ldmpub commented Jan 4, 2026

Stop at line 306
<!-- Settings -->

For reference: first PR was #417

@ldmpub ldmpub changed the title French Review part 2 of n (n unknown 🤣) [French Translation] Part 2 of n (n is unknown 🤣) Jan 4, 2026
Just review not going ahead ...
@ldmpub ldmpub closed this Jan 4, 2026
@ldmpub ldmpub deleted the ldmpub-fr-review-2 branch January 4, 2026 17:48
@ldmpub ldmpub restored the ldmpub-fr-review-2 branch January 4, 2026 17:58
@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 4, 2026

Note for myself
PR automatically closed after branch renamed from ldmpub-fr-review-2 to ldmpub-fr-review ; then branch / old name restored => no data loss but this PR remains "closed" 😕.

@Razeeman Razeeman reopened this Jan 5, 2026
@Razeeman
Copy link
Owner

Razeeman commented Jan 5, 2026

Cont from #417 (comment)

Thanks a lot for your detailed review of this Merge Request 🙏.

Several general remarks:

  1. french translation of the app is yet of poor quality despite your awareness
  2. to ease and improve translation you may have a look to online translation tools. I personally strongly recommend using Weblate (link to my profile) ; Weblate offers a "free hosted solution" for FOSS project and is quite easy to operate with GitHub
  3. Question: is there a quick and easy way to get an updated apk to check new translations in context running the app?
  4. Personally, and since several years !, I'm trying to find an Android app to track my time during "my business" ... I will give this app a try during Q1 2026 but I already miss an easy way to track "vacation days".
  1. Agree, I used Google Translate for a lot of strings, so it's not good.
  2. Weblate would be great, need to look into it.
  3. Should be possible to build apk from github actions here https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml by clicking on "run workflow". It may not build because there are some apostrophes in this PR that need to be escaped with slash.
  4. Depends on what do you want to do with vacations data later? The easiest way would be to create an activity " Vacation" and track it.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 5, 2026

Hi,

Regarding your answer: "3. Should be possible to build apk from github actions here https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml by clicking on "run workflow". It may not build because there are some apostrophes in this PR that need to be escaped with slash."

3.1 Using escape character should be handled (automatically) in an other way ... translator shouldn't be annoyed by this kind of "technical constraint"😕. What do you think?
3.2 At https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml, I can not see how to run the workflow (it looks like this job has never been launched before), do I miss something / an authorization in the current repo ? In my own repo the job failed to run => see

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 5, 2026

Regarding answer "4. Depends on what do you want to do with vacations data later? The easiest way would be to create an activity " Vacation" and track it."
That's what I'm doing but I need to work more on my knowledge of the app to change tracking units depending on activities (track Work duration is in minutes, track Vacation duration should be in Days)

@Razeeman
Copy link
Owner

Razeeman commented Jan 7, 2026

3.1 Using escape character should be handled (automatically) in an other way ... translator shouldn't be annoyed by this kind of "technical constraint"😕. What do you think?

Would be cool, unfortunately I don't know if Android development tools has this kind of automation.

3.2 At https://github.com/Razeeman/Android-SimpleTimeTracker/actions/workflows/github_build.yml, I can not see how to run the workflow (it looks like this job has never been launched before), do I miss something / an authorization in the current repo ? In my own repo the job failed to run => see

It hasn't been run for a long time, and got broken, and was failing. Should be working now in dev branch. After the successful run, there will be an artifact available for download.

That's what I'm doing but I need to work more on my knowledge of the app to change tracking units depending on activities (track Work duration is in minutes, track Vacation duration should be in Days)

There is a duration format option, but it is global for all activities unfortunately.

@Razeeman
Copy link
Owner

Razeeman commented Jan 7, 2026

Also can I mention you in the app as a translator and what name should be used for this?

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 7, 2026

Also can I mention you in the app as a translator and what name should be used for this?

No mention yet before I have performed a full review of the app translation and before I become, hopefully, a daily user of the app🤞.

@Razeeman
Copy link
Owner

Sounds good. How about this one?

Show untracked time only within the selected range.

"Consider" is a bit ambiguous it seems.

I'll change it on the main branch and translate other languages through chatgpt.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 14, 2026

Perfect 👍.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 20, 2026

Hi,

Please find my final proposal tested in the app itself (thanks to the easy "build workflow" 👍)

It may not be perfect but far much better.

Ready to discuss these changes (remarks may lead to add new translation strings, change of source / english string and even UI rework 😉).

Copy link
Owner

@Razeeman Razeeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left few comments to discuss.

I made changes on dev branch ... now I copy them here ...
@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 21, 2026

Full review done: changes or comments.

It's very hard for me to navigate between comment while seeing the english XML, the old "french" one and the new one (my suggestions). Any advice to easy my work?

@Razeeman
Copy link
Owner

Unfortunately not sure there is an easier way than opening several files side by side.

@Razeeman
Copy link
Owner

If you don't mind I'll merge and fix some inconsistencies in dev. Also will mention you in translators as "Nam". Please leave a comment if another name should be used for this.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 29, 2026

Hi,

Fine, use the username you want Nam / Ldmpub ... or something else 😂.

What do you mean by "fix some inconsistencies in dev"?

@Razeeman
Copy link
Owner

There are few unresolved issues left, I assumed you have no time to look into them.

@Razeeman Razeeman merged commit f7081ad into Razeeman:dev Jan 29, 2026
1 check passed
@Razeeman
Copy link
Owner

Made some changes.

<string name="change_record_type_categories_empty">Aucune catégorie modifiée</string>
to
<string name="change_record_type_categories_empty">Aucune catégorie définie</string>

<string name="running_records_types_empty">Bienvenue. Pour commencer, ajoutez les activités que vous souhaitez enregistrer. Appuyez sur le bouton \'%s\' pour créer une activité personnalisée ou sur \'%s\' pour créer une activité à partir d\'un modèle.</string>
to
<string name="running_records_types_empty">Pour commencer, ajoutez les activités que vous souhaitez enregistrer. Appuyez sur le bouton \'%s\' pour créer une activité personnalisée ou sur \'%s\' pour créer une activité à partir d\'un modèle.</string>

<string name="data_edit_change_activity">Basculer</string>
to
<string name="data_edit_change_activity">Modifier l\'activité</string>

<string name="shortcut_navigation_timers">Gérer et chronométrer les activités</string>
to
<string name="shortcut_navigation_timers">Chronomètres</string>

<string name="shortcut_navigation_records">Historique des enregistrements</string>
to
<string name="shortcut_navigation_records">Enregistrements</string>

@Razeeman
Copy link
Owner

Thank you very much for the help!

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 30, 2026

I will have a look this weekend.

Is there an estimated time for next app release on Google play including this new french translation?

@Razeeman
Copy link
Owner

Probably this weekend or the next one.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 31, 2026

Thanks for our collaboration.

Eager to use, daily, the new version of the app 😉.

<string name="data_edit_change_activity">Modifier l\'activité</string> is correct but I'm not sure how it will be displayed 'in" a button.

@ldmpub
Copy link
Contributor Author

ldmpub commented Jan 31, 2026

I have some app improvements to suggest (most of them about UI) ... I will create issues for discussion.

@ldmpub ldmpub deleted the ldmpub-fr-review-2 branch January 31, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants