Adjusts hydration indices to match RasCAL-1 - #429
Merged
Merged
Conversation
Collaborator
|
Hi Paul,
Can you check if the standard layers example still works with this change?
I did a quick mod on to fix the custom models one, but it seemed to break the Standard Layers!
A
From: Paul Sharp ***@***.***>
Date: Wednesday, 3 December 2025 at 09:54
To: RascalSoftware/RAT ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [RascalSoftware/RAT] Adjusts hydration indices to match RasCAL-1 (PR #429)
There is a discrepancy between the indexing used for determining the hydration method in RasCAL-1 and RAT. This matters for users writing custom function, so is corrected to match RasCAL-1 here.
…________________________________
You can view, comment on, or merge this pull request online at:
#429
Commit Summary
* 3a286cc<3a286cc> Adjusts hydration indices to match RasCAL-1
File Changes
(2 files<https://github.com/RascalSoftware/RAT/pull/429/files>)
* M API/projectClass/layersClass.m<https://github.com/RascalSoftware/RAT/pull/429/files#diff-781ee78cd39c4c4f7120b8477f74f21800b3adbac2bed13555f2e46e4100bbea> (4)
* M targetFunctions/common/customModelFunctions/applyHydration.m<https://github.com/RascalSoftware/RAT/pull/429/files#diff-1b0f8f5f0a3e8b8ebd05dc2d8764d1652174b8229a8fbf5fbff65c6c5e770b2d> (2)
Patch Links:
* https://github.com/RascalSoftware/RAT/pull/429.patch
* https://github.com/RascalSoftware/RAT/pull/429.diff
—
Reply to this email directly, view it on GitHub<#429>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGMNVXS4OCAXE4XHZCFQWLD372XMXAVCNFSM6AAAAACN4VEQGWVHI2DSMVQWIX3LMV43ASLTON2WKOZTGY4DSNBQGYYTCNI>.
You are receiving this because you are subscribed to this thread.
|
Collaborator
Author
|
Hi Arwel, the standard layers example looks good to me. Bear in mind that you will need to rebuild RAT for this to work, because "applyHydration.m" has been modified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a discrepancy between the indexing used for determining the hydration method in RasCAL-1 and RAT. This matters for users writing custom function, so is corrected to match RasCAL-1 here.