Rename colons in archives to support Windows#55
Open
mnogoborec wants to merge 2 commits intorelease/node/v0.4.0from
Open
Rename colons in archives to support Windows#55mnogoborec wants to merge 2 commits intorelease/node/v0.4.0from
mnogoborec wants to merge 2 commits intorelease/node/v0.4.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to add Windows support to archive import testing by introducing a mechanism to restore colons in archive filenames. On Windows, archive files that contain colons are stored with underscores (since Windows doesn't allow colons in filenames except for drive letters). The PR creates a prepare_archives() function that copies these files to a temporary directory and restores the colons before testing, and refactors the three archive import tests to use this new function.
Changes:
- Add
prepare_archives()helper function to copy archive files and restore colons in filenames - Refactor
import_config()to accept anarchives_pathparameter instead of using a hardcoded path - Update three test functions to call
prepare_archives()and use the new parameter - Add
#[cfg(not(target_os = "windows"))]gate to the test module
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/node/src/tests/test_archive_import.rs | Add prepare_archives() function and refactor test setup to use parameterized archive paths |
| src/node/src/archive_import/mod.rs | Exclude tests from Windows with #[cfg(not(target_os = "windows"))] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.