Skip to content

Rename colons in archives to support Windows#55

Open
mnogoborec wants to merge 2 commits intorelease/node/v0.4.0from
rename-colons
Open

Rename colons in archives to support Windows#55
mnogoborec wants to merge 2 commits intorelease/node/v0.4.0from
rename-colons

Conversation

@mnogoborec
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to add Windows support to archive import testing by introducing a mechanism to restore colons in archive filenames. On Windows, archive files that contain colons are stored with underscores (since Windows doesn't allow colons in filenames except for drive letters). The PR creates a prepare_archives() function that copies these files to a temporary directory and restores the colons before testing, and refactors the three archive import tests to use this new function.

Changes:

  • Add prepare_archives() helper function to copy archive files and restore colons in filenames
  • Refactor import_config() to accept an archives_path parameter instead of using a hardcoded path
  • Update three test functions to call prepare_archives() and use the new parameter
  • Add #[cfg(not(target_os = "windows"))] gate to the test module

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/node/src/tests/test_archive_import.rs Add prepare_archives() function and refactor test setup to use parameterized archive paths
src/node/src/archive_import/mod.rs Exclude tests from Windows with #[cfg(not(target_os = "windows"))]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants