Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the GetConfigParams liteserver query to properly handle the CFG_FROM_PREV_KEY_BLOCK mode, which retrieves configuration from a previous key block instead of the current block state.
Changes:
- Consolidates the
get_all_config_paramsfunction into a more flexibleget_config_paramsfunction that handles both regular config retrieval and retrieval from previous key blocks - Implements a new
get_prev_key_blockfunction that locates the previous key block for a given block ID using the masterchain state's prev_blocks information - Adds support for the
CFG_NEED_PREV_BLOCKSflag to conditionally include prev_blocks validation in config retrieval - Updates the
GetConfigAllquery handler to use the new unified function - Extends test utilities to support prev_blocks configuration in master state generation
- Adds comprehensive test coverage for key block resolution with proper edge case handling (blocks before key blocks should fail)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/node/src/network/liteserver.rs | Consolidates config retrieval logic, implements key block resolution with proper error handling, and updates query handlers |
| src/node/src/tests/test_helper.rs | Adds prev_blocks field to GenMasterStateParams and implements support for populating prev_blocks in generated master states |
| src/node/src/tests/test_liteserver.rs | Adds comprehensive test with helper function to verify CFG_FROM_PREV_KEY_BLOCK mode works correctly with proper key block lookup and error cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lapo4kaKek
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix liteserver
GetConfigParamsquery withCFG_FROM_PREV_KEY_BLOCKmode