Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Docker-based workflow to build MIGraphX in a TheRock-style ROCm environment installed via pip, and documents how to use it.
Changes:
- Added a new Dockerfile that creates a ROCm SDK Python venv and wires
/opt/rocmto the TheRock SDK layout. - Added a new install/build guide describing how to build MIGraphX using the
therockpackage backend inside that container.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/docker/dockerfile.therock | New Ubuntu 24.04 image that installs ROCm SDK (nightlies) via pip into a venv and installs rbuild. |
| docs/install/build-migraphx-therock.md | New guide documenting building MIGraphX using the TheRock environment and MIGRAPHX_PACKAGE_BACKEND=therock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+43
| Launch an interactive container with GPU device access and a workspace mount (adjust paths and image name to match your setup): | ||
|
|
||
| ```bash | ||
| docker run -it --network=host --device=/dev/kfd --device=/dev/dri --group-add video \ | ||
| -v $HOME/code:/workspace \ | ||
| migraphx-therock:latest | ||
| ``` | ||
|
|
||
| Inside the container, work from your MIGraphX source tree (for example under `/workspace/AMDMIGraphX` if you cloned into `$HOME/code` on the host). | ||
|
|
There was a problem hiding this comment.
The container example mounts the repo under /workspace, but the Dockerfile sets WORKDIR /work, and later text assumes the source tree is under /workspace/.... Consider aligning the Dockerfile WORKDIR and the documented mount point (or update the example) to avoid confusing users.
…N_MINIMUM for ROCm dependencies because of cmake4.0 in TheROCK
…ault", "pre-installed", and "therock" respectively, in CMake configuration
…ssion instead of generator expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for building when TheRock was installed via PIP
Technical Details
Created a docker that installs TheRock via pip, added build instructions via a .md file
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable