Skip to content

fix: Handle error when Northstar download fails#224

Open
GeckoEidechse wants to merge 4 commits intomainfrom
fix/handle-failed-download
Open

fix: Handle error when Northstar download fails#224
GeckoEidechse wants to merge 4 commits intomainfrom
fix/handle-failed-download

Conversation

@GeckoEidechse
Copy link
Copy Markdown
Member

In case of download failure return an error message.

Should resolve https://northstar-kv.sentry.io/issues/4014183248/

image

@GeckoEidechse
Copy link
Copy Markdown
Member Author

Sentry doesn't let me link Sentry<->GitHub issues without a subscription which costs 20$+ a month >:(

@GeckoEidechse GeckoEidechse added the bug Something isn't working label Mar 21, 2023
@Alystrasz
Copy link
Copy Markdown
Collaborator

Alystrasz commented May 4, 2023

What is the expected behaviour of download failure?
I tried to provoke a crash shutting down my Internet connection during a forced reinstall, but only got an "Unable to open zip archive" error message, both with main and this branch.

@GeckoEidechse
Copy link
Copy Markdown
Member Author

What is the expected behaviour of download failure?

It should be Failed downloading Northstar <error message here>

I tried to provoke a crash shutting down my Internet connection during a forced reinstall, but only got an "Unable to open zip archive" error message, both with main and this branch.

Did it maybe download too fast so by the time you disconnected the connection the download already finished? Although that wouldn't explain the error regarding opening the zip file...

@github-actions github-actions Bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working merge conflicts Blocked by merge conflicts, waiting on the author to resolve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants