feat(vector3utils): Add Vector3Utils.volume and unit tests for vector3utils and physicsutils - #821
Merged
Merged
Conversation
…3utils and physicsutils Adds Vector3Utils.volume and uses it in PhysicsUtils.estimateBuoyancyContribution. Gives both packages a runnable test target and specs for every module: Vector3Utils, Vector3SerializationUtils, RandomVector3Utils, PhysicsUtils and RxPhysicsUtils. Fixes PhysicsUtils.getConnectedParts returning the root part twice. The engine already includes the calling part in GetConnectedParts, so the extra insert double-counted its mass in applyForce and acceleratePart.
Deploy Results
1 package deployed, 1 passed, 0 failed in 8.6s · View logs Test Results
6 packages tested, 6 passed, 0 failed in 18.2s · View logs |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Vector3Utils.volume and uses it in PhysicsUtils.estimateBuoyancyContribution. Both vector3utils and physicsutils now have a test target and specs for every module. Also fixes PhysicsUtils.getConnectedParts returning the root part twice, which double-counted its mass in applyForce and acceleratePart.