Skip to content

Conversation

@RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 22, 2025

Summary

Add multi-selector and simple selector for cloning Alert Rules

Screenshots / Recordings

https://www.loom.com/share/569ea3d28e5643a5b3f617ecf3290eb0

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 55.94406% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.79%. Comparing base (1ee7056) to head (5e5d108).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...lert-rules-clone-modal/alert-rules-clone-modal.tsx 62.16% 16 Missing and 12 partials ⚠️
...ting/alert-rules-overview/alert-rules-overview.tsx 47.72% 21 Missing and 2 partials ⚠️
.../alert-rules-action-bar/alert-rules-action-bar.tsx 61.90% 7 Missing and 1 partial ⚠️
...b/hooks/use-services-search/use-services-search.ts 0.00% 3 Missing ⚠️
...ng/organization-alerting/organization-alerting.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2252      +/-   ##
===========================================
+ Coverage    48.38%   48.79%   +0.40%     
===========================================
  Files         1202     1209       +7     
  Lines        21148    21076      -72     
  Branches      6264     6213      -51     
===========================================
+ Hits         10232    10283      +51     
+ Misses        8923     8805     -118     
+ Partials      1993     1988       -5     
Flag Coverage Δ
unittests 48.79% <55.94%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…3 and refactor services search to support multiple cluster IDs
@RemiBonnet RemiBonnet marked this pull request as ready for review December 30, 2025 09:23
@RemiBonnet RemiBonnet requested a review from rmnbrd December 30, 2025 09:25
@RemiBonnet
Copy link
Member Author

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

@RemiBonnet
Copy link
Member Author

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(alerting): clone behavior - 2025-12-30T09:38:58Z

Another comment will be posted when deployments are finished

@RemiBonnet
Copy link
Member Author

Qovery Preview

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console

@RemiBonnet RemiBonnet merged commit a3fed49 into staging Dec 30, 2025
10 checks passed
@RemiBonnet RemiBonnet deleted the feat/alerting-clone branch December 30, 2025 14:36
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.260.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants