Skip to content

Conversation

@facelessuser
Copy link
Collaborator

This reverts commit 07dfa4e.

This does not fully work as advertised.

@facelessuser
Copy link
Collaborator Author

@waylan I am requesting this gets reverted. This was done with only a little testing, and once more testing is done, it is revealed this does not fully work. For instance, this works:

[`Text` and `Test`]

[`Text` and `Test`]: http://example.com

But this doesn't:

Start [`Text` and `Test`] End

[`Text` and `Test`]: http://example.com

There are some incorrect assumptions being made in the original commit that do not hold up.

@facelessuser
Copy link
Collaborator Author

To be clear, an assumption was made in the code change that assumes the Backticks processor will get the reference, enclosed with [] and will be able to reject it. But this only works in the very simple case where [`Text`] is the only text. As soon as you add any content before or after the reference, the logic no longer works. While the provided tests do work, in the real world, references will be embedded in paragraphs, and this will not actually solve the issue for most people.

@waylan waylan merged commit 9933a0a into Python-Markdown:master Dec 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants