Corrected frame-based Cheetah3 acquisition #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb5g
requested changes
Feb 12, 2026
| False if initialization failed otherwise True | ||
| """ | ||
| self.controller = self.ini_detector_init(slave_controller = controller, new_controller = Cheetah3() ) | ||
| self.controller = self.ini_detector_init(slave_controller = controller, new_controller = Cheetah3()) |
There was a problem hiding this comment.
please use new scheme:
if self.is_master:
self.controller = Cheetah3()
#add the other bits that are below
else:
self.controller = controller
initialized = True| Result | ||
| ------ | ||
| """ | ||
| self.config = Config() |
There was a problem hiding this comment.
for ease of use you don't have to place the config as a class attribute as it is a Singleton object. It means you can import it anywhere it will always point to the same object.
Then in the usage you can replace:
self.controller.config.config["CHEETAH3"]["file_paths"]['bpc']by
config("CHEETAH3", "file_paths", 'bpc')to obtain the value
| self.controller.config.add_bpc_file(param.value()) | ||
| elif param.name() == 'dacs_file_path' : | ||
| self.controller.config.refresh() | ||
| self.settings.child('file_paths_lists','bpc_file_paths_list').setLimits(self.controller.config.config["CHEETAH3"]["file_paths"]['bpc']) |
There was a problem hiding this comment.
simplify the call to your config object (see my comment on your cheetah3 python file below)
| """ | ||
| save_folders = self.config["CHEETAH3"]["file_paths"]['data'] | ||
| save_folders.append(folder_path) | ||
| self.config["CHEETAH3"]["file_paths"]['dacs'] = save_folders |
There was a problem hiding this comment.
replace this by:
self.config["CHEETAH3", "file_paths", "dacs"] = save_foldersfor simplicity
| maintainers = [ | ||
| {name = "Name Surname", email = "myname@test.fr"}, | ||
| #todo: list here all maintainers of your plugin | ||
| {name = "Adrien Teurtrie", email = "adrien.teurtrie@♥cemes.fr"}, |
| :target: https://pypi.org/project/pymodaq_plugins_template/ | ||
| :alt: Latest Version | ||
|
|
||
| .. image:: https://readthedocs.org/projects/pymodaq/badge/?version=latest |
| * PyMoDAQ’s version. | ||
| * Operating system’s version. | ||
| * What manufacturer’s drivers should be installed to make this plugin run? | ||
| * PyMoDAQ’s version : 5.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Main changes