Repository navigation
Network logo sizes: equal area instead of equal height - #84
Merged
Merged
Conversation
A shared max-height let wide wordmarks like Visma fill their cell while the nearly square UPM mark shrank to a fraction of its size. Each logo now gets the area of a fixed square, so wide logos come out long and low and tall ones narrow and high, and they read as the same weight. Used by both the footer and the partner grid. Closes #80 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Esikatselu on poistettu, koska tämä pull request on suljettu. |
Contributor
Author
|
@nlinnanen huomasiks tän töissä xdd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Problem
Network logos were capped by a shared max-height (28 px in the footer, 44 px in the partner grid). Wide wordmarks like Visma and Nokia filled their cell while the nearly square UPM mark ended up a fraction of their size.
Fix
New partial
partner-logo.htmlgives each logo the area of a fixed square (34 px side in the footer, 48 px in the grid) and derives width/height from the logo's aspect ratio. Wide logos come out long and low, tall ones narrow and high, so they read as the same visual weight. CSS no longer caps height;max-width: 100%still shrinks a logo to fit its cell.Footer at 375 px wide, before → after: UPM ~23×28 → 31×38, Visma full cell width → 72×16.
Footer logos are now
loading="lazy", as the grid's already were.Tested
Built with Hugo and checked the footer at mobile width and the partner grid on
/en/yrityssuhteet/at desktop width.🤖 Generated with Claude Code