Repository navigation
Signed-in menu links on public pages - #82
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The public HTML still names neither the gallery nor Kiltiskamera. A small script asks the gate for the member landing page, the address the sign-in button already names, and copies the rows the member build marks data-signed-in into the same places in the menus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Esikatselu on poistettu, koska tämä pull request on suljettu. |
PTER and the meeting minutes are grey labels in the public build, which may not name member addresses. The labels now carry data-members, and signed-in.js swaps each for the member build's link once the gate says the reader is signed in: in the mega menu, the phone menu and the sidebar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lolman420
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #81, which added Kiltiskamera to the menus. Public pages are static, so until now a member browsing them saw neither the signed-in-only links nor working links to member pages. This PR fixes both without the public HTML naming any of those addresses.
Signed-in-only links (Galleria, Kiltiskamera)
signedInrowsdata-signed-inin the member build. The public build getsdata-signed-in-probe="/fi/jasenille/", which is the same door the sign-in button already points at.assets/js/signed-in.jsfetches that address withredirect: "manual". A signed-out reader gets the Keycloak redirect, and nothing changes. A member gets the member build of the page, and the script copies itsdata-signed-inrows into the same positions in the desktop mega menu and the phone menu.Member pages (PTER, Kokouspöytäkirjat / Meeting minutes)
data-members="<label>"in the mega menu, the phone menu and the sidebar. For a signed-in reader, the script swaps each label for the matching link from the member build's header. The public HTML still holds no member address.Caching
sessionStoragefor the tab, so signed-out readers make only one probe request. Any member-tree page resets it, and signing in always lands on one.Testing
check-trees.sh.🤖 Generated with Claude Code