Repository navigation
Run tests for PR #2079 - #2083
Closed
alerickson wants to merge 2 commits into
Closed
alerickson wants to merge 2 commits into
alerickson wants to merge 2 commits into
Conversation
Upload the config blob using its matching digest and advertise its two-byte size in the OCI manifest. Add focused config and upload regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d4b68cd-b7b7-476b-a441-4e443201413b
Choose the config filename before creating, hashing, and uploading it, and remove the helper's unreported path substitution. Cover publishing with an existing module config.json without overwriting its content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d4b68cd-b7b7-476b-a441-4e443201413b
alerickson
requested review from
Sydney Smith (SydneyhSmith),
Aditya Patwardhan (adityapatwardhan),
Anam Navied (anamnavi) and
shammu1
as code owners
November 9, 2026 22:14
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the container registry publishing fix and its regression tests.
No open issues 🎉
What changed in this PR
This PR corrects container registry publishing so the uploaded config blob matches the digest and size recorded in the package manifest, and adds regression tests.
Changes:
- Uploads an empty JSON object (
{}) as the config blob and records its byte size in the manifest. - Uses a unique config filename to preserve existing module files.
- Adds tests for config content, digest, manifest metadata, upload failures, and publishing with an existing
config.json.
| File | Description |
|---|---|
test/PublishPSResourceTests/ContainerRegistryConfig.Tests.ps1 |
Adds config blob and publishing regression tests using a mock HTTP handler. |
src/code/ContainerRegistryServerAPICalls.cs |
Aligns config creation, upload, and manifest metadata. |
Review effort: Balanced
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
8 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.