Fix: datasource() method is called twice in v6.x with Collection datasource

src/DataSource/ProcessDataSource.php

@@ -10,6 +10,8 @@
 
 class ProcessDataSource
 {
+    public mixed $datasource = null;
+
     public function __construct(
         public PowerGridComponent $component,
         public array $properties = [],
@@ -25,20 +27,25 @@ public static function make(PowerGridComponent $powerGridComponent, array $prope
      */
     public function get(bool $isExport = false): array
     {
+        if (is_null($this->datasource)) {
+            $this->datasource = $this->component->datasource($this->properties);
+        }
+
+        $datasource = is_object($this->datasource) ? clone $this->datasource : $this->datasource;
+
         $processors = [
             CollectionProcessor::class,
             ScoutBuilderProcessor::class,
         ];
 
         foreach ($processors as $processor) {
-            // @phpstan-ignore-next-line
-            if ($processor::match($this->component->datasource($this->properties))) {
+            if ($processor::match($datasource)) {
                 $instance = new $processor($this->component, $isExport);
 
-                return $instance->process($this->properties);
+                return $instance->process($this->properties, $datasource);
             }
         }
 
-        return (new ModelProcessor($this->component, $isExport))->process($this->properties);
+        return (new ModelProcessor($this->component, $isExport))->process($this->properties, $datasource);
     }
 }

src/DataSource/Processors/CollectionProcessor.php

@@ -17,9 +17,9 @@ public static function match(mixed $key): bool
             || is_iterable($key);
     }
 
-    public function process(array $properties = []): array
+    public function process(array $properties = [], mixed $datasource = null): array
     {
-        $datasource = $this->component->datasource($properties);
+        $datasource = $datasource ?? $this->component->datasource($properties);
 
         $collection = new BaseCollection($datasource);
 

src/DataSource/Processors/ModelProcessor.php

@@ -15,9 +15,9 @@ public static function match(mixed $key): bool
         return true;
     }
 
-    public function process(array $properties = []): array
+    public function process(array $properties = [], mixed $datasource = null): array
     {
-        $datasource = $this->component->datasource($properties);
+        $datasource = $datasource ?? $this->component->datasource($properties);
 
         $this->setCurrentTable($datasource);
 

src/DataSource/Processors/ScoutBuilderProcessor.php

@@ -15,10 +15,10 @@ public static function match(mixed $key): bool
         return $key instanceof ScoutBuilder;
     }
 
-    public function process(array $properties = []): array
+    public function process(array $properties = [], mixed $datasource = null): array
     {
         /** @var ScoutBuilder $datasource */
-        $datasource = $this->component->datasource($properties);
+        $datasource = $datasource ?? $this->component->datasource($properties);
 
         /** @var ScoutBuilder $query */
         $query = app(Pipeline::class)

src/PowerGridComponent.php

@@ -141,7 +141,13 @@ private function getRecordsFromCache(): mixed
         $customTag = strval(data_get($this->setUp, 'cache.tag'));
         $ttl = intval(data_get($this->setUp, 'cache.ttl'));
 
-        $tag = $prefix.($customTag ?: 'powergrid-'.$this->datasource()->getModel()->getTable().'-'.$this->tableName);
+        if (filled($customTag)) {
+            $tag = $prefix.$customTag;
+        } else {
+            $datasource = $this->datasource();
+            $table = method_exists($datasource, 'getModel') ? $datasource->getModel()->getTable() : $this->tableName;
+            $tag = $prefix.'powergrid-'.$table.'-'.$this->tableName;
+        }
         $cacheKey = implode('-', $this->getCacheKeys());
 
         /** @var array $results */

src/Traits/ExportableJob.php

@@ -61,7 +61,7 @@ private function prepareToExport(array $properties = []): Eloquent\Collection|Co
                 : $currentTable.'.'.$property;
         };
 
-        $results = $this->componentTable->datasource($this->properties ?? []) // @phpstan-ignore-line
+        $results = $processDataSource->datasource
             ->where(function ($query) {
                 app()->makeWith(SearchHandlerContract::class, [
                     'component' => $this->componentTable,

src/Traits/WithExport.php

@@ -167,7 +167,7 @@ public function prepareToExport(bool $selected = false): Eloquent\Collection|Col
             $filtered = $processDataSource->component->checkboxValues;
         }
 
-        if ($processDataSource->component->datasource() instanceof Collection) {
+        if ($processDataSource->datasource instanceof Collection) {
             if ($filtered) {
                 $results = $processDataSource->get(isExport: true)['results']
                     ->whereIn($this->primaryKey, $filtered);
@@ -179,7 +179,7 @@ public function prepareToExport(bool $selected = false): Eloquent\Collection|Col
 
             $dataTransformer = new DataTransformer($processDataSource->component);
 
-            return $dataTransformer->transform($processDataSource->component->datasource())->collection;
+            return $dataTransformer->transform($processDataSource->datasource)->collection;
         }
 
         /** @phpstan-ignore-next-line */
@@ -195,7 +195,7 @@ public function prepareToExport(bool $selected = false): Eloquent\Collection|Col
 
         $queryOptions = data_get($this->setUp, 'exportable.queryOptions', []);
 
-        $results = $processDataSource->component->datasource()
+        $results = $processDataSource->datasource
             ->where(function ($query) {
                 app()->makeWith(SearchHandlerContract::class, [
                     'component' => $this,

tests/Feature/DatasourceCallCountTest.php

@@ -0,0 +1,107 @@
+<?php
+
+use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Support\Collection;
+use PowerComponents\LivewirePowerGrid\{Column, Facades\PowerGrid, PowerGridComponent, PowerGridFields};
+use PowerComponents\LivewirePowerGrid\Tests\Concerns\Models\Dish;
+
+use function PowerComponents\LivewirePowerGrid\Tests\Plugins\livewire;
+
+class DatasourceCountTable extends PowerGridComponent
+{
+    public string $tableName = 'datasource-count-table';
+
+    public static int $calls = 0;
+
+    public function datasource(): Collection
+    {
+        self::$calls++;
+
+        return collect([
+            ['id' => 1, 'name' => 'Name 1'],
+            ['id' => 2, 'name' => 'Name 2'],
+        ]);
+    }
+
+    public function fields(): PowerGridFields
+    {
+        return PowerGrid::fields()
+            ->add('id')
+            ->add('name');
+    }
+
+    public function columns(): array
+    {
+        return [
+            Column::make('ID', 'id'),
+            Column::make('Name', 'name'),
+        ];
+    }
+}
+
+class EloquentDatasourceCountTable extends PowerGridComponent
+{
+    public string $tableName = 'eloquent-datasource-count-table';
+
+    public static int $calls = 0;
+
+    public function datasource(): Builder
+    {
+        self::$calls++;
+
+        return Dish::query();
+    }
+
+    public function fields(): PowerGridFields
+    {
+        return PowerGrid::fields()
+            ->add('id')
+            ->add('name');
+    }
+
+    public function columns(): array
+    {
+        return [
+            Column::make('ID', 'id'),
+            Column::make('Name', 'name'),
+        ];
+    }
+}
+
+it('calls collection datasource() only once', function () {
+    DatasourceCountTable::$calls = 0;
+
+    livewire(DatasourceCountTable::class)
+        ->assertOk();
+
+    expect(DatasourceCountTable::$calls)->toBe(1);
+});
+
+it('calls collection datasource() only once when searching', function () {
+    DatasourceCountTable::$calls = 0;
+
+    livewire(DatasourceCountTable::class)
+        ->set('search', 'Name 1')
+        ->assertOk();
+
+    expect(DatasourceCountTable::$calls)->toBe(2);
+});
+
+it('calls eloquent datasource() only once', function () {
+    EloquentDatasourceCountTable::$calls = 0;
+
+    livewire(EloquentDatasourceCountTable::class)
+        ->assertOk();
+
+    expect(EloquentDatasourceCountTable::$calls)->toBe(1);
+});
+
+it('calls eloquent datasource() only once when searching', function () {
+    EloquentDatasourceCountTable::$calls = 0;
+
+    livewire(EloquentDatasourceCountTable::class)
+        ->set('search', 'Dish 1')
+        ->assertOk();
+
+    expect(EloquentDatasourceCountTable::$calls)->toBe(2);
+});