Skip to content

fix(flags): skip client-only definition warnings - #333

Merged
marandaneto merged 2 commits into
mainfrom
fix/client-only-flag-warnings-eqe9hG
Nov 6, 2026
Merged

fix(flags): skip client-only definition warnings#333
marandaneto merged 2 commits into
mainfrom
fix/client-only-flag-warnings-eqe9hG

Conversation

@marandaneto

@marandaneto marandaneto commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

💡 Motivation and Context

Server SDKs currently warn when loaded client-only feature flags cannot resolve locally, even when the application never evaluates them. This follows the warning contract in sdk-specs #169 and the Node fix in posthog-js #5532.

Filter client-only definitions in the warning collector without changing the shared reason classifier. API and shared-cache loads still retain all definitions and local results. New runtime-test clients are shut down after each example.

Only the exact runtime string client is excluded from definition-load warnings. Server, all, null and absent runtimes remain eligible. Keep client definitions, local values and unresolved reasons unchanged. Remove client-only flags from warning history so they warn again if their runtime changes back. Dependency evaluation and Node's separate bulk-fallback optimization are not changed.

The changeset explicitly includes a posthog-rails patch release alongside core Ruby. Rails' dependency propagation and this explicit intent combine into one release, so Rails users receive the fixed core SDK without a duplicate version bump.

💚 How did you test it?

  • Actual warning regressions failed before the fix. The warning suite passes with 57 examples, including 44 new examples.

  • Review caught a test-client poller leak. A delayed two-example reproduction failed before cleanup and passed after adding shutdown in the after hook.

  • Final full RSpec run: 2,152 examples, 0 failures and 40 existing pending cases. Full RuboCop and public API checks passed.

  • Validation used available Ruby 4.0.7, not the repository's Ruby 3.2.2 target or the full CI version matrix.

  • Pi autoreview of the final committed branch against origin/main reported no findings. The scoped test-quality and independent review checks are complete.

  • pnpm changeset status confirms one patch release each for posthog-ruby and posthog-rails, with the same planned versions as dependency propagation alone.

📝 Checklist

  • All commits are signed (see Commit signing)
  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Added patch release entries for posthog-ruby and posthog-rails.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented with Pi subagents, Git and the repository's native test tools. Separate Pi reviewers checked the patches and test coverage. Final review used the isolated Pi autoreview helper. The changes follow the merged SDK contract and keep warning collection separate from evaluation.

@marandaneto marandaneto self-assigned this Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown

posthog-ruby-sync Compliance Report

Date: 2026-11-06T12:36:27.844269+00:00
Duration: 55820ms

⚠️ Some Tests Failed

39/47 tests passed, 8 failed

Capture Tests

⚠️ 23/30 tests passed, 7 failed

View Details
Test Status Duration
Format Validation.Event Has Required Fields ✅ 8ms
Format Validation.Event Has Uuid ✅ 5ms
Format Validation.Event Has Lib Properties ✅ 5ms
Format Validation.Distinct Id Is String ✅ 7ms
Format Validation.Token Is Present ✅ 7ms
Format Validation.Custom Properties Preserved ✅ 5ms
Format Validation.Event Has Timestamp ✅ 7ms
Format Validation.Non Utc Event Timestamp Is Converted To Utc ✅ 6ms
Retry Behavior.Retries On 503 ✅ 5243ms
Retry Behavior.Does Not Retry On 400 ❌ 6ms
Retry Behavior.Does Not Retry On 401 ❌ 5ms
Retry Behavior.Respects Retry After Header ✅ 8011ms
Retry Behavior.Implements Backoff ❌ 241ms
Retry Behavior.Retries On 500 ✅ 5153ms
Retry Behavior.Retries On 502 ✅ 5159ms
Retry Behavior.Retries On 504 ✅ 5116ms
Retry Behavior.Max Retries Respected ❌ 438ms
Deduplication.Generates Unique Uuids ✅ 14ms
Deduplication.Preserves Uuid On Retry ✅ 5142ms
Deduplication.Preserves Uuid And Timestamp On Retry ✅ 10305ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry ✅ 5166ms
Deduplication.No Duplicate Events In Batch ✅ 16ms
Deduplication.Different Events Have Different Uuids ✅ 9ms
Compression.Sends Gzip When Enabled ✅ 5ms
Batch Format.Uses Proper Batch Structure ✅ 6ms
Batch Format.Flush With No Events Sends Nothing ✅ 3ms
Batch Format.Multiple Events Batched Together ❌ 15ms
Error Handling.Does Not Retry On 403 ❌ 4ms
Error Handling.Does Not Retry On 413 ❌ 5ms
Error Handling.Retries On 408 ✅ 5145ms

Failures

retry_behavior.does_not_retry_on_400

500, message='Internal Server Error', url='http://sdk-adapter:8080/capture'

retry_behavior.does_not_retry_on_401

500, message='Internal Server Error', url='http://sdk-adapter:8080/capture'

retry_behavior.implements_backoff

500, message='Internal Server Error', url='http://sdk-adapter:8080/capture'

retry_behavior.max_retries_respected

500, message='Internal Server Error', url='http://sdk-adapter:8080/capture'

batch_format.multiple_events_batched_together

Expected 1 requests, got 5

error_handling.does_not_retry_on_403

500, message='Internal Server Error', url='http://sdk-adapter:8080/capture'

error_handling.does_not_retry_on_413

500, message='Internal Server Error', url='http://sdk-adapter:8080/capture'

Feature_Flags Tests

⚠️ 16/17 tests passed, 1 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id ✅ 8ms
Request Payload.Flags Request Uses V2 Query Param ✅ 8ms
Request Payload.Flags Request Hits Flags Path Not Decide ✅ 7ms
Request Payload.Flags Request Omits Authorization Header ✅ 6ms
Request Payload.Token In Flags Body Matches Init ✅ 6ms
Request Payload.Groups Round Trip ✅ 5ms
Request Payload.Groups Default To Empty Object ✅ 5ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False ✅ 5ms
Request Payload.Disable Geoip Omitted Defaults To False ❌ 6ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key ✅ 6ms
Request Lifecycle.No Flags Request On Init Alone ✅ 2ms
Request Lifecycle.No Flags Request On Normal Capture ✅ 5ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests ✅ 7ms
Request Lifecycle.Mock Response Value Is Returned To Caller ✅ 5ms
Retry Behavior.Retries Flags On 502 ✅ 109ms
Retry Behavior.Retries Flags On 504 ✅ 148ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event ✅ 7ms

Failures

request_payload.disable_geoip_omitted_defaults_to_false

Field 'geoip_disable' not found in /flags request body at path 'geoip_disable'. Available keys: ['distinct_id', 'groups', 'person_properties', 'group_properties', 'flag_keys_to_evaluate', 'token']

@github-actions

github-actions Bot commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown

posthog-ruby-async Compliance Report

Date: 2026-11-06T12:37:12.679114+00:00
Duration: 98538ms

⚠️ Some Tests Failed

46/47 tests passed, 1 failed

Capture Tests

✅ 30/30 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields ✅ 10ms
Format Validation.Event Has Uuid ✅ 105ms
Format Validation.Event Has Lib Properties ✅ 109ms
Format Validation.Distinct Id Is String ✅ 107ms
Format Validation.Token Is Present ✅ 107ms
Format Validation.Custom Properties Preserved ✅ 108ms
Format Validation.Event Has Timestamp ✅ 107ms
Format Validation.Non Utc Event Timestamp Is Converted To Utc ✅ 107ms
Retry Behavior.Retries On 503 ✅ 5313ms
Retry Behavior.Does Not Retry On 400 ✅ 2109ms
Retry Behavior.Does Not Retry On 401 ✅ 2108ms
Retry Behavior.Respects Retry After Header ✅ 8116ms
Retry Behavior.Implements Backoff ✅ 15724ms
Retry Behavior.Retries On 500 ✅ 5209ms
Retry Behavior.Retries On 502 ✅ 5208ms
Retry Behavior.Retries On 504 ✅ 5212ms
Retry Behavior.Max Retries Respected ✅ 15623ms
Deduplication.Generates Unique Uuids ✅ 111ms
Deduplication.Preserves Uuid On Retry ✅ 5212ms
Deduplication.Preserves Uuid And Timestamp On Retry ✅ 10418ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry ✅ 5215ms
Deduplication.No Duplicate Events In Batch ✅ 111ms
Deduplication.Different Events Have Different Uuids ✅ 107ms
Compression.Sends Gzip When Enabled ✅ 107ms
Batch Format.Uses Proper Batch Structure ✅ 108ms
Batch Format.Flush With No Events Sends Nothing ✅ 6ms
Batch Format.Multiple Events Batched Together ✅ 112ms
Error Handling.Does Not Retry On 403 ✅ 2109ms
Error Handling.Does Not Retry On 413 ✅ 2109ms
Error Handling.Retries On 408 ✅ 5212ms

Feature_Flags Tests

⚠️ 16/17 tests passed, 1 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id ✅ 108ms
Request Payload.Flags Request Uses V2 Query Param ✅ 107ms
Request Payload.Flags Request Hits Flags Path Not Decide ✅ 108ms
Request Payload.Flags Request Omits Authorization Header ✅ 107ms
Request Payload.Token In Flags Body Matches Init ✅ 107ms
Request Payload.Groups Round Trip ✅ 107ms
Request Payload.Groups Default To Empty Object ✅ 108ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False ✅ 107ms
Request Payload.Disable Geoip Omitted Defaults To False ❌ 107ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key ✅ 108ms
Request Lifecycle.No Flags Request On Init Alone ✅ 3ms
Request Lifecycle.No Flags Request On Normal Capture ✅ 106ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests ✅ 114ms
Request Lifecycle.Mock Response Value Is Returned To Caller ✅ 106ms
Retry Behavior.Retries Flags On 502 ✅ 252ms
Retry Behavior.Retries Flags On 504 ✅ 210ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event ✅ 110ms

Failures

request_payload.disable_geoip_omitted_defaults_to_false

Field 'geoip_disable' not found in /flags request body at path 'geoip_disable'. Available keys: ['distinct_id', 'groups', 'person_properties', 'group_properties', 'flag_keys_to_evaluate', 'token']

@marandaneto
marandaneto marked this pull request as ready for review November 6, 2026 12:31
@marandaneto
marandaneto requested a review from a team as a code owner November 6, 2026 12:31
@github-actions

github-actions Bot commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown

SDK performance: posthog-ruby

Benchmarks completed. No changes flagged for review.

Flags require at least a 5% change in the median and all six pairs agreeing on direction. This is a noise filter, not proof of a performance change or a CI gate.

View all results
Test Measurement Before PR With PR Change Assessment
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Queue an event (32-byte payload)
Shard: capture		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​; head:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​
Queue an event (32-byte payload)
Shard: capture		 Allocations per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​; head:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​
Queue an event (4,096-byte payload)
Shard: capture		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​; head:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​
Queue an event (4,096-byte payload)
Shard: capture		 Allocations per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​; head:​ Background serialization has no public enqueue completion boundary; use completed-delivery workloads for process-wide allocation counts.​
Evaluate all 10 flags
Shard: flags-scaling		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate all 100 flags
Shard: flags-scaling		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate all 1,000 flags
Shard: flags-scaling		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate one boolean flag
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a cohort-filtered flag
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a flag (early match)
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a flag (late match)
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a flag (no match)
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a property-filtered flag
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a regex-filtered flag
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a rollout flag
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Evaluate a multivariate flag
Shard: flags-single		 Allocated memory per operation — — — unavailable; base:​ unsupported; head:​ unsupported; base:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​; head:​ Ruby has no cumulative allocated-byte counter here; retained ObjectSpace bytes are not allocation volume.​
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Allocations per operation 56.27 count/op 56.27 count/op No observed change Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Time per operation 107.87 µs/op 108.06 µs/op 0.2% more time Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Idle process memory (RSS) 28.4 MiB 28.41 MiB <0.1% more memory Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Observed peak process memory (RSS) 31.16 MiB 31.17 MiB <0.1% more memory Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Managed heap after settling 5.27 MiB 5.27 MiB <0.1% more memory Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Process memory after settling (RSS) 30.4 MiB 30.41 MiB <0.1% more memory Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Process CPU time per operation 17.6 µs/op 18.94 µs/op 7.6% more time Not flagged
Capture and deliver events (32-byte payload, burst)
Shard: capture		 Lifetime peak process memory (RSS) 30.97 MiB 30.93 MiB 0.1% less memory Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Allocations per operation 58.65 count/op 58.65 count/op No observed change Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Time per operation 107.69 µs/op 107.8 µs/op 0.1% more time Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Idle process memory (RSS) 33.21 MiB 33.21 MiB No observed change Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Observed peak process memory (RSS) 42.8 MiB 43.17 MiB 0.9% more memory Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Managed heap after settling 9.14 MiB 9.14 MiB <0.1% more memory Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Process memory after settling (RSS) 40.66 MiB 37.81 MiB 7% less memory Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Process CPU time per operation 25.55 µs/op 25.36 µs/op 0.7% less time Not flagged
Capture and deliver events (4,096-byte payload, burst)
Shard: capture		 Lifetime peak process memory (RSS) 42.7 MiB 43.04 MiB 0.8% more memory Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Allocations per operation 58.68 count/op 58.68 count/op No observed change Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Time per operation 1.01 ms/op 1.01 ms/op <0.1% more time Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Idle process memory (RSS) 28.26 MiB 28.33 MiB 0.2% more memory Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Observed peak process memory (RSS) 30.42 MiB 30.42 MiB <0.1% less memory Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Managed heap after settling 5.27 MiB 5.27 MiB <0.1% more memory Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Process memory after settling (RSS) 30.42 MiB 30.42 MiB <0.1% less memory Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Process CPU time per operation 27 µs/op 27.61 µs/op 2.3% more time Not flagged
Capture and deliver events (32-byte payload, steady)
Shard: capture		 Lifetime peak process memory (RSS) 30.42 MiB 30.42 MiB <0.1% less memory Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Allocations per operation 58.68 count/op 58.68 count/op No observed change Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Time per operation 1.01 ms/op 1.01 ms/op <0.1% less time Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Idle process memory (RSS) 33.17 MiB 33.12 MiB 0.1% less memory Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Observed peak process memory (RSS) 40.51 MiB 40.47 MiB <0.1% less memory Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Managed heap after settling 9.14 MiB 9.14 MiB <0.1% more memory Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Process memory after settling (RSS) 40.28 MiB 40.23 MiB 0.1% less memory Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Process CPU time per operation 32.83 µs/op 32.97 µs/op 0.4% more time Not flagged
Capture and deliver events (4,096-byte payload, steady)
Shard: capture		 Lifetime peak process memory (RSS) 40.94 MiB 40.86 MiB 0.2% less memory Not flagged
Queue an event (32-byte payload)
Shard: capture		 Caller-thread CPU time per operation 7.18 µs/op 7.26 µs/op 1.2% more time Not flagged
Queue an event (32-byte payload)
Shard: capture		 Time per operation 7.17 µs/op 7.26 µs/op 1.2% more time Not flagged
Queue an event (4,096-byte payload)
Shard: capture		 Caller-thread CPU time per operation 7.18 µs/op 7.15 µs/op 0.5% less time Not flagged
Queue an event (4,096-byte payload)
Shard: capture		 Time per operation 7.18 µs/op 7.14 µs/op 0.5% less time Not flagged
Evaluate all 10 flags
Shard: flags-scaling		 Allocations per operation 343.02 count/op 343.02 count/op No observed change Not flagged
Evaluate all 10 flags
Shard: flags-scaling		 Time per operation 152.27 µs/op 151.81 µs/op 0.3% less time Not flagged
Evaluate all 10 flags
Shard: flags-scaling		 Process CPU time per operation 152.27 µs/op 151.8 µs/op 0.3% less time Not flagged
Evaluate all 100 flags
Shard: flags-scaling		 Allocations per operation 3,324 count/op 3,324 count/op No observed change Not flagged
Evaluate all 100 flags
Shard: flags-scaling		 Time per operation 1.47 ms/op 1.45 ms/op 1% less time Not flagged
Evaluate all 100 flags
Shard: flags-scaling		 Process CPU time per operation 1.47 ms/op 1.45 ms/op 1% less time Not flagged
Evaluate all 1,000 flags
Shard: flags-scaling		 Allocations per operation 33,113.56 count/op 33,113.62 count/op <0.1% more Not flagged
Evaluate all 1,000 flags
Shard: flags-scaling		 Time per operation 14.66 ms/op 14.47 ms/op 1.3% less time Not flagged
Evaluate all 1,000 flags
Shard: flags-scaling		 Process CPU time per operation 14.65 ms/op 14.47 ms/op 1.3% less time Not flagged
Evaluate 1,000 flags under concurrent load
Shard: flags-memory		 Idle process memory (RSS) 39.3 MiB 39.27 MiB <0.1% less memory Not flagged
Evaluate 1,000 flags under concurrent load
Shard: flags-memory		 Observed peak process memory (RSS) 40.8 MiB 40.7 MiB 0.2% less memory Not flagged
Evaluate 1,000 flags under concurrent load
Shard: flags-memory		 Managed heap after settling 7.97 MiB 7.97 MiB <0.1% more memory Not flagged
Evaluate 1,000 flags under concurrent load
Shard: flags-memory		 Process memory after settling (RSS) 39.43 MiB 39.4 MiB <0.1% less memory Not flagged
Evaluate 1,000 flags under concurrent load
Shard: flags-memory		 Lifetime peak process memory (RSS) 40.37 MiB 40.32 MiB 0.1% less memory Not flagged
Refresh 1,000 flag definitions
Shard: flags-memory		 Idle process memory (RSS) 38.01 MiB 38.07 MiB 0.2% more memory Not flagged
Refresh 1,000 flag definitions
Shard: flags-memory		 Observed peak process memory (RSS) 41.21 MiB 41.22 MiB <0.1% more memory Not flagged
Refresh 1,000 flag definitions
Shard: flags-memory		 Managed heap after settling 9.48 MiB 9.48 MiB <0.1% more memory Not flagged
Refresh 1,000 flag definitions
Shard: flags-memory		 Process memory after settling (RSS) 41.19 MiB 41.13 MiB 0.1% less memory Not flagged
Refresh 1,000 flag definitions
Shard: flags-memory		 Lifetime peak process memory (RSS) 41.21 MiB 41.18 MiB <0.1% less memory Not flagged
Evaluate one boolean flag
Shard: flags-single		 Allocations per operation 38 count/op 38 count/op No observed change Not flagged
Evaluate one boolean flag
Shard: flags-single		 Time per operation 9.31 µs/op 9.24 µs/op 0.7% less time Not flagged
Evaluate one boolean flag
Shard: flags-single		 Process CPU time per operation 9.31 µs/op 9.24 µs/op 0.7% less time Not flagged
Evaluate a cohort-filtered flag
Shard: flags-single		 Allocations per operation 38 count/op 38 count/op No observed change Not flagged
Evaluate a cohort-filtered flag
Shard: flags-single		 Time per operation 11.52 µs/op 11.51 µs/op <0.1% less time Not flagged
Evaluate a cohort-filtered flag
Shard: flags-single		 Process CPU time per operation 11.52 µs/op 11.51 µs/op <0.1% less time Not flagged
Evaluate a flag (early match)
Shard: flags-single		 Allocations per operation 55 count/op 55 count/op No observed change Not flagged
Evaluate a flag (early match)
Shard: flags-single		 Time per operation 16.16 µs/op 16.16 µs/op <0.1% less time Not flagged
Evaluate a flag (early match)
Shard: flags-single		 Process CPU time per operation 16.16 µs/op 16.16 µs/op <0.1% less time Not flagged
Evaluate a flag (late match)
Shard: flags-single		 Allocations per operation 76 count/op 76 count/op No observed change Not flagged
Evaluate a flag (late match)
Shard: flags-single		 Time per operation 22.64 µs/op 22.6 µs/op 0.2% less time Not flagged
Evaluate a flag (late match)
Shard: flags-single		 Process CPU time per operation 22.64 µs/op 22.6 µs/op 0.2% less time Not flagged
Evaluate a flag (no match)
Shard: flags-single		 Allocations per operation 67 count/op 67 count/op No observed change Not flagged
Evaluate a flag (no match)
Shard: flags-single		 Time per operation 20.85 µs/op 20.69 µs/op 0.8% less time Not flagged
Evaluate a flag (no match)
Shard: flags-single		 Process CPU time per operation 20.85 µs/op 20.69 µs/op 0.8% less time Not flagged
Evaluate a property-filtered flag
Shard: flags-single		 Allocations per operation 34 count/op 34 count/op No observed change Not flagged
Evaluate a property-filtered flag
Shard: flags-single		 Time per operation 9.38 µs/op 9.42 µs/op 0.5% more time Not flagged
Evaluate a property-filtered flag
Shard: flags-single		 Process CPU time per operation 9.38 µs/op 9.42 µs/op 0.5% more time Not flagged
Evaluate a regex-filtered flag
Shard: flags-single		 Allocations per operation 99 count/op 99 count/op No observed change Not flagged
Evaluate a regex-filtered flag
Shard: flags-single		 Time per operation 25.66 µs/op 25.88 µs/op 0.9% more time Not flagged
Evaluate a regex-filtered flag
Shard: flags-single		 Process CPU time per operation 25.66 µs/op 25.88 µs/op 0.9% more time Not flagged
Evaluate a rollout flag
Shard: flags-single		 Allocations per operation 31 count/op 31 count/op No observed change Not flagged
Evaluate a rollout flag
Shard: flags-single		 Time per operation 8.32 µs/op 8.35 µs/op 0.3% more time Not flagged
Evaluate a rollout flag
Shard: flags-single		 Process CPU time per operation 8.32 µs/op 8.34 µs/op 0.3% more time Not flagged
Evaluate a multivariate flag
Shard: flags-single		 Allocations per operation 37 count/op 37 count/op No observed change Not flagged
Evaluate a multivariate flag
Shard: flags-single		 Time per operation 10.33 µs/op 10.42 µs/op 0.8% more time Not flagged
Evaluate a multivariate flag
Shard: flags-single		 Process CPU time per operation 10.33 µs/op 10.42 µs/op 0.8% more time Not flagged

Values are medians of paired measurements. Not flagged does not mean unchanged. Unavailable means a measurement could not be provided, not zero. Estimated allocation measurements retain their instrumentation uncertainty. RSS measures the whole process, not just SDK allocations; observed peaks are sampled checkpoints. Paired ranges in the diagnostics describe variability, not confidence intervals.

Each shard uses its own runner; compare Before PR against With PR within a row, not across shards.

Compared 6f660771d9430dce128dfeab3063a2a53dabc420 → 4d06e4a53ca876770ac7b96f2ba0bd8761147de7.

Full report and diagnostics

102 metric rows; 102 rows shown in all results. Omitted or shortened data remain in comparison.json, including per-runner environments, resource limits, measurement methods, samples and checkpoints.

ioannisj
ioannisj approved these changes Nov 6, 2026
View reviewed changes

@ioannisj ioannisj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 An AI agent wrote this on behalf of @ioannisj.

No findings. The client filter in _unresolvable_flags matches the spec and the Node fix in posthog-js #5532, and the new specs cover both the API and shared-cache loads.

@marandaneto
marandaneto merged commit 2cad6bc into main Nov 6, 2026
30 of 31 checks passed
@marandaneto
marandaneto deleted the fix/client-only-flag-warnings-eqe9hG branch November 6, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioannisj ioannisj ioannisj approved these changes

Assignees

@marandaneto marandaneto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marandaneto @ioannisj