docs(parser): audit Codex v0.147.0 MCP SDK 3.0.0 and 2026-07-28 protocol (#222) - #225
Merged
Conversation
…col for #222 Verified both changes against the openai/codex source (PRs #36001, #35724, #35725, #35590, #35742): they only alter the wire protocol between Codex and MCP servers (SDK type renames, paginated server/discover requests, multi-round tools/call negotiation, non-blocking server startup). None touch codex-rs/protocol, app-server/src/dynamic_tools.rs, or the tool_search_call/ tool_search_call_output mechanism that codex-trace parses, so the rollout JSONL shape is unaffected and no parser change is needed. Documented the audit as a code comment for future reference. Closes #222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex v0.147.0 bumped the bundled MCP SDK to 3.0.0 (#36001) and added an opt-in MCP 2026-07-28 protocol revision (#35724, #35725, #35590, #35742). This PR verifies both concerns raised in #222 directly against the actual
openai/codexsource and confirms neither requires a parser change.What was verified
Meta→MetaObject) and improves OAuth transport error handling. No changes tocodex-rs/protocolor rollout serialization.server/discoverrequests, multi-roundtools/callnegotiation, and non-blocking server startup. That pagination/negotiation is resolved internally by Codex before it ever builds thedynamic_toolsfield or tool-search results — none of the four PRs touchcodex-rs/protocol(rollout item types),app-server/src/dynamic_tools.rs, or the model-facingtool_search_call/tool_search_call_outputmechanism codex-trace already parses (issue [Compat] Codex v0.142.2: MCP tools now use tool search by default — discovery mechanism changed in session output #161's fix). The rollout JSONL shape is unchanged.Documented this audit as a code comment in
turn.rsnext to the existing tool-search handling, following the same "verify against real upstream source, document non-applicable findings" pattern used in #213 for issue #210 — since both parts of #222 turned out to be non-applicable, there's no new field or parsing logic to add.Testing
cargo test(360 tests): all passnpx vitest run(148 tests): all passcargo clippy -- -D warnings: cleantsc --noEmit,oxfmt --check: cleanoxlint: clean except one pre-existing, unrelated warning inMarkdownRenderer.tsxCloses #222