Skip to content

Miners back to work when ore regenerated#2157

Open
TaranDahl wants to merge 9 commits intoPhobos-developers:developfrom
TaranDahl:MinerBackToWork
Open

Miners back to work when ore regenerated#2157
TaranDahl wants to merge 9 commits intoPhobos-developers:developfrom
TaranDahl:MinerBackToWork

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

@TaranDahl TaranDahl commented Mar 28, 2026

  • Now miners will no longer withdraw from the Harvest mission due to mineral depletion and will periodically attempt to return to work.

@TaranDahl TaranDahl added Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels Mar 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl TaranDahl requested a review from NetsuNegi March 28, 2026 03:00
@CCCP84
Copy link
Copy Markdown

CCCP84 commented Mar 28, 2026

I checked it works, the harvesters come to life one after the other, not at the same time, it looks very good

@CCCP84
Copy link
Copy Markdown

CCCP84 commented Mar 28, 2026

I think this should be made permanently enabled and not so that players have to enable it in the map or something else. no one will want to disable this option. there is no reason for this

@CCCP84
Copy link
Copy Markdown

CCCP84 commented Mar 28, 2026

Besides, it seems to solve this problem too:

CnCNet/cncnet-yr-client-package#303

in general this is a very significant improvement over the original game. There's always been a problem with these harvesters. In this regard, everyone has already gotten used to living with it. now the convenience will be significantly increased

@TaranDahl
Copy link
Copy Markdown
Contributor Author

I think this should be made permanently enabled

Fine by me. What do you think? @Metadorius

@CCCP84
Copy link
Copy Markdown

CCCP84 commented Mar 28, 2026

How does it work? Is there some kind of timer that checks for ore at certain times? If so, you can make the delay much longer because checking more frequently is unnecessary and could cause lags with a lot of harvesters. Or no? I think checking every one or 1.5 minutes would be fine.
Although apparently there is no timer here, right?

@TaranDahl
Copy link
Copy Markdown
Contributor Author

How does it work? Is there some kind of timer that checks for ore at certain times?

Yeah. The mission timer is used for the interval.

If so, you can make the delay much longer because checking more frequently is unnecessary and could cause lags with a lot of harvesters. Or no?

I used a hardcoded value, 100 frames. Regarding whether it will cause lag, I think there's no need to worry. This check cycle is longer than the original check cycle of the "miner returns to work" behavior (which is about 1 second). If the original CMIN didn't cause lag, then the new behavior won't cause lag either.

@Metadorius
Copy link
Copy Markdown
Member

Fine by me. What do you think? @Metadorius

I agree

@TaranDahl
Copy link
Copy Markdown
Contributor Author

image Fucked by git

@TaranDahl TaranDahl requested a review from Coronia March 30, 2026 09:24
@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested ❓Unhardcoding / Customization Make something more tweakable Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants